* fix FindUnitSymtable for exception symtables, resolves #24801 and #39974

  * more consistent naming of exceptsymtable enumeration symbol

compiler/symconst.pas

@@ -682,7 +682,7 @@ type
     localsymtable,         { subroutine symtable             }
     parasymtable,          { arguments symtable              }
     withsymtable,          { with operator symtable          }
-    stt_excepTSymtable,    { try/except symtable             }
+    exceptsymtable,        { try/except symtable             }
     exportedmacrosymtable, { }
     localmacrosymtable,    { }
     enumsymtable,          { symtable for enum members       }

compiler/symdef.pas

@@ -2643,7 +2643,7 @@ implementation
              the module is compiled, so we can get crashes on high level targets
              if they still need it while e.g. writing assembler code }
            while assigned(insertstack) and
-                 (insertstack^.symtable.symtabletype in [stt_exceptsymtable,withsymtable]) do
+                 (insertstack^.symtable.symtabletype in [exceptsymtable,withsymtable]) do
              insertstack:=insertstack^.next;
            if not assigned(insertstack) then
              internalerror(200602044);

compiler/symtable.pas

@@ -277,7 +277,7 @@ interface
           procedure insertdef(def:TDefEntry);override;
         end;
 
-       tstt_excepTSymtable = class(TSymtable)
+       tstt_exceptsymtable = class(TSymtable)
        public
           constructor create;
        end;
@@ -2828,7 +2828,7 @@ implementation
     constructor tstt_excepTSymtable.create;
       begin
         inherited create('');
-        symtabletype:=stt_excepTSymtable;
+        symtabletype:=exceptsymtable;
       end;
 
 

compiler/symtype.pas

@@ -263,6 +263,7 @@ implementation
                 result:=st;
                 exit;
               end;
+            exceptsymtable,
             recordsymtable,
             enumsymtable,
             arraysymtable,
@@ -528,12 +529,12 @@ implementation
           won't be saved to the ppu and as a result we can get unreachable
           defs when reloading the derived ones from the ppu }
         origowner:=owner;
-        while not(origowner.symtabletype in [localsymtable,staticsymtable,globalsymtable,stt_excepTSymtable]) do
+        while not(origowner.symtabletype in [localsymtable,staticsymtable,globalsymtable,exceptsymtable]) do
           origowner:=origowner.defowner.owner;
         { if the def is in an exceptionsymtable, we can't create a reusable
           def because the original one will be freed when the (always
           temprary) exceptionsymtable is freed }
-        if origowner.symtabletype=stt_excepTSymtable then
+        if origowner.symtabletype=exceptsymtable then
           internalerror(2015111701)
         else if origowner.symtabletype=localsymtable then
           result:=origowner

tests/webtbs/tw24801.pp

@@ -0,0 +1,12 @@
+program ErrorSample;
+{$mode objfpc}{$H+}
+uses
+    {$IFDEF UNIX}
+    cThreads,
+    {$ENDIF}
+  Classes,
+  uw24801;
+begin
+  if f<>'asdfasdf' then
+    halt(1);
+end.         

tests/webtbs/uw24801.pp

@@ -0,0 +1,22 @@
+unit uw24801;
+{$MODE objfpc}{$H+}
+interface
+uses
+  Classes,sysutils;
+  function f: string; inline;   //causing internal error
+implementation
+
+function f: string;
+var msg : string;
+begin
+//***** this is the block causing internal error
+      try
+        raise exception.create('asdfasdf');
+      except
+        on E: exception do begin
+          msg := E.Message;
+          result:=msg;
+        end;
+      end;
+end;
+end.