Browse Source

fcl-db: cosmetic

git-svn-id: trunk@29442 -
lacak 10 years ago
parent
commit
8ae9752530
2 changed files with 21 additions and 20 deletions
  1. 5 5
      packages/fcl-db/src/base/bufdataset.pas
  2. 16 15
      packages/fcl-db/src/sqldb/sqldb.pp

+ 5 - 5
packages/fcl-db/src/base/bufdataset.pas

@@ -546,7 +546,7 @@ type
     procedure SetFilterText(const Value: String); override; {virtual;}
     procedure SetFilterText(const Value: String); override; {virtual;}
     procedure SetFiltered(Value: Boolean); override; {virtual;}
     procedure SetFiltered(Value: Boolean); override; {virtual;}
     procedure InternalRefresh; override;
     procedure InternalRefresh; override;
-    procedure DataEvent(Event: TDataEvent; Info: Ptrint); override;
+    procedure DataEvent(Event: TDataEvent; Info: PtrInt); override;
     // virtual or methods, which can be used by descendants
     // virtual or methods, which can be used by descendants
     function GetNewBlobBuffer : PBlobBuffer;
     function GetNewBlobBuffer : PBlobBuffer;
     function GetNewWriteBlobBuffer : PBlobBuffer;
     function GetNewWriteBlobBuffer : PBlobBuffer;
@@ -2144,7 +2144,7 @@ begin
     begin
     begin
     if GetFieldIsNull(pbyte(CurrBuff),Field.FieldNo-1) then
     if GetFieldIsNull(pbyte(CurrBuff),Field.FieldNo-1) then
       Exit;
       Exit;
-    if assigned(buffer) then
+    if assigned(Buffer) then
       begin
       begin
       inc(CurrBuff,FFieldBufPositions[Field.FieldNo-1]);
       inc(CurrBuff,FFieldBufPositions[Field.FieldNo-1]);
       Move(CurrBuff^, Buffer^, GetFieldSize(FieldDefs[Field.FieldNo-1]));
       Move(CurrBuff^, Buffer^, GetFieldSize(FieldDefs[Field.FieldNo-1]));
@@ -2204,7 +2204,7 @@ begin
       Move(Buffer^, CurrBuff^, Field.DataSize);
       Move(Buffer^, CurrBuff^, Field.DataSize);
     end;
     end;
   if not (State in [dsCalcFields, dsFilter, dsNewValue]) then
   if not (State in [dsCalcFields, dsFilter, dsNewValue]) then
-    DataEvent(deFieldChange, Ptrint(Field));
+    DataEvent(deFieldChange, PtrInt(Field));
 end;
 end;
 
 
 procedure TCustomBufDataset.InternalDelete;
 procedure TCustomBufDataset.InternalDelete;
@@ -2374,7 +2374,7 @@ begin
       if not ((FUpdateBuffer[r].UpdateKind=ukDelete) and not (assigned(FUpdateBuffer[r].OldValuesBuffer))) then
       if not ((FUpdateBuffer[r].UpdateKind=ukDelete) and not (assigned(FUpdateBuffer[r].OldValuesBuffer))) then
         begin
         begin
         FCurrentIndex.GotoBookmark(@FUpdateBuffer[r].BookmarkData);
         FCurrentIndex.GotoBookmark(@FUpdateBuffer[r].BookmarkData);
-        // Synchronise the Currentbuffer to the ActiveBuffer
+        // Synchronise the CurrentBuffer to the ActiveBuffer
         CurrentRecordToBuffer(ActiveBuffer);
         CurrentRecordToBuffer(ActiveBuffer);
         Response := rrApply;
         Response := rrApply;
         try
         try
@@ -3247,7 +3247,7 @@ begin
   // Do nothing
   // Do nothing
 end;
 end;
 
 
-procedure TCustomBufDataset.DataEvent(Event: TDataEvent; Info: Ptrint);
+procedure TCustomBufDataset.DataEvent(Event: TDataEvent; Info: PtrInt);
 begin
 begin
   if Event = deUpdateState then
   if Event = deUpdateState then
     // Save DataSet.State set by DataSet.SetState (filter out State set by DataSet.SetTempState)
     // Save DataSet.State set by DataSet.SetState (filter out State set by DataSet.SetTempState)

+ 16 - 15
packages/fcl-db/src/sqldb/sqldb.pp

@@ -472,7 +472,6 @@ type
   public
   public
     constructor Create(AOwner : TComponent); override;
     constructor Create(AOwner : TComponent); override;
     destructor Destroy; override;
     destructor Destroy; override;
-    Procedure ApplyUpdates(MaxErrors: Integer); override; overload;
     procedure Prepare; virtual;
     procedure Prepare; virtual;
     procedure UnPrepare; virtual;
     procedure UnPrepare; virtual;
     procedure ExecSQL; virtual;
     procedure ExecSQL; virtual;
@@ -482,6 +481,8 @@ type
     Property Prepared : boolean read IsPrepared;
     Property Prepared : boolean read IsPrepared;
     Property SQLConnection : TSQLConnection Read GetSQLConnection Write SetSQLConnection;
     Property SQLConnection : TSQLConnection Read GetSQLConnection Write SetSQLConnection;
     Property SQLTransaction: TSQLTransaction Read GetSQLTransaction Write SetSQLTransaction;
     Property SQLTransaction: TSQLTransaction Read GetSQLTransaction Write SetSQLTransaction;
+    // overriden TBufDataSet methods
+    Procedure ApplyUpdates(MaxErrors: Integer); override; overload;
     // overriden TDataSet methods
     // overriden TDataSet methods
     Procedure Post; override;
     Procedure Post; override;
     Procedure Delete; override;
     Procedure Delete; override;
@@ -2086,10 +2087,10 @@ begin
   F.FQuery:=Self;
   F.FQuery:=Self;
   FStatement:=F;
   FStatement:=F;
 
 
-  FUpdateSQL := TStringList.Create;
-  FUpdateSQL.OnChange := @OnChangeModifySQL;
   FInsertSQL := TStringList.Create;
   FInsertSQL := TStringList.Create;
   FInsertSQL.OnChange := @OnChangeModifySQL;
   FInsertSQL.OnChange := @OnChangeModifySQL;
+  FUpdateSQL := TStringList.Create;
+  FUpdateSQL.OnChange := @OnChangeModifySQL;
   FDeleteSQL := TStringList.Create;
   FDeleteSQL := TStringList.Create;
   FDeleteSQL.OnChange := @OnChangeModifySQL;
   FDeleteSQL.OnChange := @OnChangeModifySQL;
   FRefreshSQL := TStringList.Create;
   FRefreshSQL := TStringList.Create;
@@ -2116,24 +2117,13 @@ begin
   UnPrepare;
   UnPrepare;
   FreeAndNil(FStatement);
   FreeAndNil(FStatement);
   FreeAndNil(FInsertSQL);
   FreeAndNil(FInsertSQL);
-  FreeAndNil(FDeleteSQL);
   FreeAndNil(FUpdateSQL);
   FreeAndNil(FUpdateSQL);
+  FreeAndNil(FDeleteSQL);
   FreeAndNil(FRefreshSQL);
   FreeAndNil(FRefreshSQL);
   FServerIndexDefs.Free;
   FServerIndexDefs.Free;
   inherited Destroy;
   inherited Destroy;
 end;
 end;
 
 
-Procedure TCustomSQLQuery.ApplyUpdates(MaxErrors: Integer);
-begin
-  inherited ApplyUpdates(MaxErrors);
-  If sqoAutoCommit in Options then
-    begin
-    // Retrieve rows affected for last update.
-    FStatement.RowsAffected;
-    SQLTransaction.Commit;
-    end;
-end;
-
 function TCustomSQLQuery.ParamByName(Const AParamName: String): TParam;
 function TCustomSQLQuery.ParamByName(Const AParamName: String): TParam;
 
 
 begin
 begin
@@ -2544,6 +2534,17 @@ begin
   end;
   end;
 end;
 end;
 
 
+Procedure TCustomSQLQuery.ApplyUpdates(MaxErrors: Integer);
+begin
+  inherited ApplyUpdates(MaxErrors);
+  If sqoAutoCommit in Options then
+    begin
+    // Retrieve rows affected for last update.
+    FStatement.RowsAffected;
+    SQLTransaction.Commit;
+    end;
+end;
+
 Procedure TCustomSQLQuery.Post;
 Procedure TCustomSQLQuery.Post;
 begin
 begin
   inherited Post;
   inherited Post;