Patch from Luiz Americo, bug #13221:

 * add const keyword to some string parameters
 * remove two typos: an extra semicolon in BindFields and an extra assignment in SetActive

git-svn-id: trunk@12769 -

packages/fcl-db/src/base/dataset.inc

@@ -124,7 +124,7 @@ begin
             end;
           end else FFieldNo := FieldIndex;
         end;
-      end else FFieldNo := 0;;
+      end else FFieldNo := 0;
     end;
 end;
 
@@ -1078,7 +1078,6 @@ begin
     CloseCursor;
     DoAfterClose;
     FModified:=False;
-    FModified:=False;
     end
 end;
 
@@ -2245,7 +2244,7 @@ begin
   FBuffers[0]:=TempBuf;
 end;
 
-function TDataset.GetFieldValues(Fieldname: string): Variant;
+function TDataset.GetFieldValues(const Fieldname: string): Variant;
 
 var i: Integer;
     FieldList: TList;
@@ -2264,7 +2263,7 @@ begin
   end;
 end;
 
-procedure TDataset.SetFieldValues(Fieldname: string; Value: Variant);
+procedure TDataset.SetFieldValues(const Fieldname: string; Value: Variant);
 
 var
   i : Integer;

packages/fcl-db/src/base/db.pas

@@ -658,7 +658,7 @@ type
     FDisplayValues : String;
     // First byte indicates uppercase or not.
     FDisplays : Array[Boolean,Boolean] of string;
-    Procedure SetDisplayValues(AValue : String);
+    Procedure SetDisplayValues(const AValue : String);
   protected
     function GetAsBoolean: Boolean; override;
     function GetAsString: string; override;
@@ -1186,7 +1186,7 @@ type
     procedure GetChildren(Proc: TGetChildProc; Root: TComponent); override;
     function  GetFieldClass(FieldType: TFieldType): TFieldClass; virtual;
     Function  GetfieldCount : Integer;
-    function  GetFieldValues(fieldname : string) : Variant; virtual;
+    function  GetFieldValues(const fieldname : string) : Variant; virtual;
     function  GetIsIndexField(Field: TField): Boolean; virtual;
     function  GetIndexDefs(IndexDefs : TIndexDefs; IndexTypes : TIndexOptions) : TIndexDefs;
     function  GetNextRecords: Longint; virtual;
@@ -1216,7 +1216,7 @@ type
     procedure SetFilterOptions(Value: TFilterOptions); virtual;
     procedure SetFilterText(const Value: string); virtual;
     procedure SetFound(const Value: Boolean);
-    procedure SetFieldValues(fieldname: string; Value: Variant); virtual;
+    procedure SetFieldValues(const fieldname: string; Value: Variant); virtual;
     procedure SetModified(Value: Boolean);
     procedure SetName(const Value: TComponentName); override;
     procedure SetOnFilterRecord(const Value: TFilterRecordEvent); virtual;

packages/fcl-db/src/base/fields.inc

@@ -1929,7 +1929,7 @@ begin
   DisplayValues:='True;False';
 end;
 
-Procedure TBooleanField.SetDisplayValues(AValue : String);
+Procedure TBooleanField.SetDisplayValues(const AValue : String);
 
 Var I : longint;