fcl-passrc: resolver: emit nMethodHidesMethodOfBaseType only for virtuals

git-svn-id: trunk@37721 -

packages/fcl-passrc/src/pasresolver.pp

@@ -3187,12 +3187,14 @@ begin
                and not ProcHasGroupOverload(Data^.Proc)) then
           begin
           // give a hint, that proc is hiding a proc in other scope
-          if Data^.Kind=fopkMethod then
+          if (Data^.Kind=fopkMethod) and (Proc.IsVirtual or Proc.IsOverride) then
             LogMsg(20170216151712,mtWarning,nMethodHidesMethodOfBaseType,
               sMethodHidesMethodOfBaseType,
               [Data^.Proc.Name,Proc.Parent.Name,GetElementSourcePosStr(Proc)],Data^.Proc.ProcType)
           else
-            LogMsg(20171118214523,mtHint,nFunctionHidesIdentifier,sFunctionHidesIdentifier,
+            // Delphi/FPC do not give a message when hiding a non virtual method
+            // -> emit only an Info
+            LogMsg(20171118214523,mtInfo,nFunctionHidesIdentifier,sFunctionHidesIdentifier,
               [GetElementSourcePosStr(Proc)],Data^.Proc.ProcType);
           Abort:=true;
           end;

packages/fcl-passrc/tests/tcresolver.pas

@@ -422,6 +422,7 @@ type
     Procedure TestClass_MethodOverloadMissingInDelphi;
     Procedure TestClass_MethodOverloadAncestor;
     Procedure TestClass_MethodOverloadUnit;
+    Procedure TestClass_MethodOverloadNonVirtualInfo;
     Procedure TestClass_MethodReintroduce;
     Procedure TestClass_MethodOverloadArrayOfTClass;
     Procedure TestClass_ConstructorHidesAncestorWarning;
@@ -6556,6 +6557,24 @@ begin
   CheckResolverUnexpectedHints;
 end;
 
+procedure TTestResolver.TestClass_MethodOverloadNonVirtualInfo;
+begin
+  StartProgram(false);
+  Add([
+  'type',
+  '  TObject = class',
+  '    procedure DoIt(p: pointer);',
+  '  end;',
+  '  TBird = class',
+  '    procedure DoIt(i: longint);',
+  '  end;',
+  'procedure TObject.DoIt(p: pointer); begin end;',
+  'procedure TBird.DoIt(i: longint); begin end;',
+  'begin']);
+  ParseProgram;
+  CheckResolverHint(mtInfo,nFunctionHidesIdentifier,'function hides identifier at "afile.pp(4,19)"');
+end;
+
 procedure TTestResolver.TestClass_MethodReintroduce;
 begin
   StartProgram(false);