* fixed regression of webtbs/tw4254: if a constant (wide)string can't be

    converted to a pchar at compile time, remove the cstring_to_pchar node
    because it expects a stringconstn in pass_generate_code

git-svn-id: trunk@8275 -

compiler/ncnv.pas

@@ -1183,7 +1183,17 @@ implementation
          else
            if is_pchar(resultdef) and
               is_widestring(left.resultdef) then
-             inserttypeconv(left,cansistringtype);
+             begin
+               inserttypeconv(left,cansistringtype);
+               { the second pass of second_cstring_to_pchar expects a  }
+               { strinconstn, but this may become a call to the        }
+               { widestring manager in case left contains "high ascii" }
+               if (left.nodetype<>stringconstn) then
+                 begin
+                   result:=left;
+                   left:=nil;
+                 end;
+             end;
       end;
 
 

tests/webtbs/tw4254.pp

@@ -1,3 +1,5 @@
+{$codepage utf8}
+
 { Source provided for Free Pascal Bug Report 4254 }
 { Submitted by "rimga" on  2005-08-04 }
 { e-mail: [email protected] }