Browse Source

* memleak in chm support fixed, added some comments

git-svn-id: trunk@11969 -
marco 17 years ago
parent
commit
f19e69e7e8
2 changed files with 4 additions and 3 deletions
  1. 1 1
      ide/wchmhwrap.pas
  2. 3 2
      ide/whtmlhlp.pas

+ 1 - 1
ide/wchmhwrap.pas

@@ -69,7 +69,7 @@ Constructor TChmWrapper.Create(name:string);
 
 begin
   ffs:=Classes.TFileStream.create(name,fmOpenRead);
-  fchmr:=TChmReader.Create(ffs,True);
+  fchmr:=TChmReader.Create(ffs,True); // owns ffs
   findex:=nil;
   if not fchmr.isvalidfile then
     begin

+ 3 - 2
ide/whtmlhlp.pas

@@ -1577,8 +1577,9 @@ end;
 
 constructor TChmHelpFile.Init(AFileName: string; AID: word);
 begin
-  if inherited Init(AID)=false then Fail;
-  renderer^.done;
+  if inherited Init(AID)=false then 
+    Fail;
+  Dispose(renderer,done);
   renderer:=New(PCHMTopicRenderer, Init);
   DefaultFileName:=AFileName; 
   if (DefaultFileName='') or not ExistsFile(DefaultFilename) then