Browse Source

Tweak ExtractArchive transition info.

Martijn Laan 3 months ago
parent
commit
67815aaccd
3 changed files with 4 additions and 2 deletions
  1. 2 0
      Projects/Src/Compiler.Messages.pas
  2. 1 1
      Projects/Src/Compiler.ScriptFunc.pas
  3. 1 1
      whatsnew.htm

+ 2 - 0
Projects/Src/Compiler.Messages.pas

@@ -240,6 +240,8 @@ const
   SCompilerCodeUnsupportedEventFunction = 'Event function named "%s" is no longer supported. Create a "%s" function instead';
   SCompilerCodeFunctionRenamed = 'Support function "%s" has been renamed. Use "%s" instead.';
   SCompilerCodeFunctionRenamedWithAlternative = 'Support function "%s" has been renamed. Use "%s" instead or consider using "%s".';
+  SCompilerCodeFunctionDeprecatedWithHint = 'Support function "%s" is deprecated. Use "%s" instead. %s';
+  SCompilerCodeFunctionExtractArchiveHint = 'It includes an additional parameter to optionally specify a password.';
   SCompilerCodeFunctionDeprecatedWithAlternativeAndDocs = 'Support function "%s" is deprecated. Use "%s" instead, but note that "%s" is preferred in most cases. See the "%s" topic in help file for more information.';
 
   { [Types] }

+ 1 - 1
Projects/Src/Compiler.ScriptFunc.pas

@@ -152,7 +152,7 @@ begin
   ObsoleteFunctionWarnings.Add('IsTaskSelected', Format(SCompilerCodeFunctionRenamed, ['IsTaskSelected', 'WizardIsTaskSelected']));
   ObsoleteFunctionWarnings.Add('IsX64', Format(SCompilerCodeFunctionDeprecatedWithAlternativeAndDocs, ['IsX64', 'IsX64OS', 'IsX64Compatible', 'Architecture Identifiers']));
   ObsoleteFunctionWarnings.Add('FileCopy', Format(SCompilerCodeFunctionRenamed, ['FileCopy', 'CopyFile']));
-  ObsoleteFunctionWarnings.Add('Extract7ZipArchive', Format(SCompilerCodeFunctionRenamed, ['Extract7ZipArchive', 'ExtractArchive']));
+  ObsoleteFunctionWarnings.Add('Extract7ZipArchive', Format(SCompilerCodeFunctionDeprecatedWithHint, ['Extract7ZipArchive', 'ExtractArchive', SCompilerCodeFunctionExtractArchiveHint]));
 
   RegisterConst('MaxInt', MaxInt);
 

+ 1 - 1
whatsnew.htm

@@ -122,7 +122,7 @@ issigtool --key-file="MyKey.ispublickey" verify "MyProg.dll"</pre>
     New documentation <a href="https://jrsoftware.org/ishelp/index.php?topic=setup_archiveextraction">ArchiveExtraction</a> topic has a table summarizing the differences between these methods.
   </li>
   <li>Added example script <i>CodeDownloadFiles2.iss</i> to demonstrate how to use the <tt>CreateExtractionPage</tt> support function to verify and extract a downloaded archive.</li>
-  <li>Support function <tt>ExtractArchive</tt> is new and replaces <tt>Extract7ZipArchive</tt>. The old name is still supported, but it is recommended to update your scripts to the new name and the compiler will issue a warning if you don't.</li>
+  <li>New support function <tt>ExtractArchive</tt> replaces the deprecated <tt>Extract7ZipArchive</tt>. <tt>ExtractArchive</tt> includes an additional parameter to optionally specify a password.</li>
   <li>Archive extraction now overwrites read-only files which already exist in the destination directory without prompting the user. Previously this would cause an extraction error.</li>
   <li>Archive extraction now honors the file system redirection state set by 64-bit install mode and support function <tt>EnableFsRedirection</tt>.</li>
   <li>Added new <tt>AddEx</tt> function to support class <tt>TExtractionWizardPage</tt> to add password-protected archives.</li>