Browse Source

Dual signing makes no difference on Windows 7 SP1 (single and dual both not recognized) nor on Windows 8.1 (both recognized) in my tests. So stop dual signing on builds since it slows things down. Did still dual sign previous commit since those are just one time signs so doesn't hurt.

Martijn Laan 1 year ago
parent
commit
8804666d2e
2 changed files with 1 additions and 4 deletions
  1. 1 1
      .github/workflows/build.yml
  2. 0 3
      setup.iss

+ 1 - 1
.github/workflows/build.yml

@@ -47,7 +47,7 @@ jobs:
           printf '%s\n' >setup-sign.bat \
             'mkdir tmp-unsigned' \
             'copy files tmp-unsigned' \
-            'tmp-unsigned\iscc /Sissigntool256="${{github.workspace}}\home\bin\run-signtool.bat $f" /DSIGNTOOL /DNOSHA1SIGNTOOL setup.iss'
+            'tmp-unsigned\iscc /Sissigntool256="${{github.workspace}}\home\bin\run-signtool.bat $f" /DSIGNTOOL setup.iss'
       - name: build issrc
         run: |
           "set DELPHIXEROOT=$env:DELPHIXEROOT" | Out-File -NoNewline -Encoding ascii compilesettings.bat

+ 0 - 3
setup.iss

@@ -38,9 +38,6 @@ TimeStampsInUTC=yes
 TouchDate=none
 TouchTime=00:00
 #ifdef SIGNTOOL
-#ifndef NOSHA1SIGNTOOL
-SignTool=issigntool
-#endif
 SignTool=issigntool256
 SignedUninstaller=yes
 #endif