Cosmetic/slight hardening

comparison.pas

@@ -1830,13 +1830,13 @@ begin
     cbComparedDatabase.Items.Add(ServerName + '-' + fmMain.RegisteredDatabases[i].RegRec.Title);
   end;
 
-  for i:= 1 to High(FDBObjectsList) do
+  for i:= Low(FDBObjectsList) to High(FDBObjectsList) do
     FDBObjectsList[i]:= TStringList.Create;
 
-  for i:= 1 to High(FDBExistingObjectsList) do
+  for i:= Low(FDBExistingObjectsList) to High(FDBExistingObjectsList) do
     FDBExistingObjectsList[i]:= TStringList.Create;
 
-  for i:= 1 to High(FDBRemovedObjectsList) do
+  for i:= Low(FDBRemovedObjectsList) to High(FDBRemovedObjectsList) do
     FDBRemovedObjectsList[i]:= TStringList.Create;
 end;
 

copytable.pas

@@ -167,9 +167,7 @@ begin
     end;
   end;
 
-
   dmSysTables.sqQuery.Close;
-
 end;
 
 procedure TfmCopyTable.Init(SourceIndex: Integer; ATableName: string);
@@ -177,7 +175,7 @@ var
   i: Integer;
   Count: Integer;
 begin
-  dmSysTables.sqQuery.Close;
+  dmSysTables.sqQuery.Close; //todo: (low priority) is this really necessary?
   FSourceIndex:= SourceIndex;
   laSourceDatabase.Caption:= fmMain.RegisteredDatabases[SourceIndex].RegRec.Title;
   cbDestDatabase.Clear;

editdatafullrec.pas

@@ -91,7 +91,6 @@ begin
   FSQLTrans:= fmMain.RegisteredDatabases[dbIndex].SQLTrans;
   sqEditTable.DataBase:= FIBConnection;
 
-
   sqEditTable.SQL.Text:= 'select * from ' +  ATableName;
   sqEditTable.Open;
   bbSave.Visible:= true;

neweditfield.pas

@@ -43,7 +43,7 @@ type
     OldAllowNull: Boolean;
     OldOrder: Integer;
     OldDefault: string;
-    OldDesciption: string;
+    OldDescription: string;
     procedure Init(dbIndex: Integer; TableName: string; FormMode: TFormMode;
       FieldName, FieldType, DefaultValue, Description: string; FSize, FOrder: Integer; AllowNull: Boolean; RefreshButton: TBitBtn);
 
@@ -130,7 +130,7 @@ begin
     end;
 
     // Description
-    if edDescription.Text <> OldDesciption then
+    if edDescription.Text <> OldDescription then
     begin
       Line:= Line + 'UPDATE RDB$RELATION_FIELDS set RDB$DESCRIPTION = ''' + edDescription.Text +
         '''  where RDB$FIELD_NAME = ''' + UpperCase(Trim(edFieldName.Text)) +
@@ -184,7 +184,7 @@ begin
   OldAllowNull:= AllowNull;
   OldOrder:= FOrder;
   OldDefault:= DefaultValue;
-  OldDesciption:= Description;
+  OldDescription:= Description;
 
   edFieldName.Text:= OldFieldName;
   seSize.Value:= OldFieldSize;
@@ -192,7 +192,7 @@ begin
   cxAllowNull.Checked:= OldAllowNull;
   seOrder.Value:= OldOrder;
   edDefault.Text:= OldDefault;
-  edDescription.Text:= OldDesciption;
+  edDescription.Text:= OldDescription;
   if FormMode = foEdit then
   begin
     bbAdd.Caption:= 'Update';
@@ -203,7 +203,6 @@ begin
     bbAdd.Caption:= 'Add';
     Caption:= 'Add new in : ' + TableName;
   end;
-
 end;
 
 initialization

permissionmanage.pas

@@ -575,13 +575,11 @@ begin
   cbProcUsers.Items.CommaText:= cbUsers.Items.CommaText;
   cbViewsUsers.Items.CommaText:= cbUsers.Items.CommaText;
 
-
-
   // Update table permissions
   UpdatePermissions;
 
   // stored procedures
-  UPdateProcPermissions;
+  UpdateProcPermissions;
 
   // Roles
   clbRoles.Clear;

querywindow.pas

@@ -998,7 +998,7 @@ begin
   FRegRec:= fmMain.RegisteredDatabases[dbIndex].RegRec;
 
   // Set instances of FIBConnection and SQLTransaction for the current Query Window
-  setTransactionIsolation(FSQLTrans.Params);
+  SetTransactionIsolation(FSQLTrans.Params);
   FSQLTrans.DataBase:= FIBConnection;
 
   // Set connection parameters to FIBConnection
@@ -1011,7 +1011,7 @@ begin
     Self.FIBConnection.Role:= RegRec.Role;
   end;
 
-  // Get current database tables to be hilighted in SQL query editor
+  // Get current database tables to be highlighted in SQL query editor
   SynSQLSyn1.TableNames.CommaText:= fmMain.GetTableNames(dbIndex);
   SynCompletion1.ItemList.AddStrings(SynSQLSyn1.TableNames);
   SortSynCompletion;

tablemanage.pas

@@ -439,7 +439,6 @@ begin
     SQLQuery1.DataBase:= FIBConnection;
     SQLQuery2.Close;
     SQLQuery2.DataBase:= FIBConnection;
-
   except
     on e: exception do
     begin