Database, right click: recalculate index statistics functionality. DB script: ignore error when creating RDB$ADMIN role which exists on FB 2.5+ databases.

TurboBird.lpi

@@ -283,6 +283,7 @@
         <Filename Value="calen.pas"/>
         <IsPartOfProject Value="True"/>
         <ComponentName Value="fmCalen"/>
+        <HasResources Value="True"/>
         <ResourceBaseClass Value="Form"/>
         <UnitName Value="Calen"/>
       </Unit23>

main.lfm

@@ -5,7 +5,7 @@ object fmMain: TfmMain
   Width = 1024
   ActiveControl = tvMain
   Caption = 'TurboBird Admin for FireBird'
-  ClientHeight = 617
+  ClientHeight = 621
   ClientWidth = 1024
   Color = clWhite
   Font.Name = 'Sans'
@@ -18,7 +18,7 @@ object fmMain: TfmMain
   LCLVersion = '1.2.2.0'
   object tvMain: TTreeView
     Left = 0
-    Height = 596
+    Height = 601
     Top = 0
     Width = 360
     Align = alLeft
@@ -38,14 +38,14 @@ object fmMain: TfmMain
   end
   object Splitter1: TSplitter
     Left = 360
-    Height = 596
+    Height = 601
     Top = 0
     Width = 14
     Beveled = True
   end
   object PageControl1: TPageControl
     Left = 377
-    Height = 589
+    Height = 594
     Top = 3
     Width = 644
     ActivePage = TabSheet1
@@ -65,8 +65,8 @@ object fmMain: TfmMain
     object TabSheet1: TTabSheet
       BorderWidth = 1
       Caption = 'Main'
-      ClientHeight = 559
-      ClientWidth = 640
+      ClientHeight = 563
+      ClientWidth = 636
       Font.Color = clNavy
       Font.Name = 'Arial'
       ParentFont = False
@@ -506,8 +506,8 @@ object fmMain: TfmMain
   end
   object StatusBar1: TStatusBar
     Left = 0
-    Height = 21
-    Top = 596
+    Height = 20
+    Top = 601
     Width = 1024
     Panels = <    
       item
@@ -1890,6 +1890,11 @@ object fmMain: TfmMain
       }
       OnClick = lmBackupClick
     end
+    object lmRecalculateStatistics: TMenuItem
+      Caption = 'Recalculate indexes'
+      Hint = 'Recalculate index statistics. Can be useful after large loads/edits'
+      OnClick = lmRecalculateStatisticsClick
+    end
     object lmSweep: TMenuItem
       Caption = 'Sweep DB'
       Bitmap.Data = {

main.pas

@@ -51,6 +51,7 @@ type
     lmCompare: TMenuItem;
     lmGetIncrementGen: TMenuItem;
     lmDropTable: TMenuItem;
+    lmRecalculateStatistics: TMenuItem;
     mnExit: TMenuItem;
     mnCreateDB: TMenuItem;
     mnRegDB: TMenuItem;
@@ -170,6 +171,7 @@ type
     procedure lmViewTriggerClick(Sender: TObject);
     procedure lmViewUDFClick(Sender: TObject);
     procedure lmDropTableClick(Sender: TObject);
+    procedure lmRecalculateStatisticsClick(Sender: TObject);
     procedure mnExitClick(Sender: TObject);
     procedure mnCreateDBClick(Sender: TObject);
     procedure mnRegDBClick(Sender: TObject);
@@ -1877,14 +1879,13 @@ begin
         ScriptAllPermissions(dbIndex, List);
         Lines.AddStrings(List);
         Lines.Add('');
-
       end;
       QueryWindow.Show;
     except
-      on e: exception do
+      on E: Exception do
       begin
         Screen.Cursor:= crDefault;
-        ShowMessage(e.Message);
+        ShowMessage(E.Message);
       end;
     end;
   finally
@@ -2292,6 +2293,7 @@ var
 begin
   dbIndex:= PtrInt(tvMain.Selected.Data);
   FireBirdServices:= TFirebirdServices.Create;
+  Screen.Cursor:= crSQLWait;
   try
     FireBirdServices.VerboseOutput:= True;
     with FireBirdServices, RegisteredDatabases[dbIndex] do
@@ -2309,17 +2311,18 @@ begin
         StartSweep;
         while ServiceQuery(S) do
           Lines:= Lines + S;
-
-        ShowMessage('Sweep database: ' + AdbName + ' Completed');
+        Screen.Cursor:= crDefault;
+        ShowMessage('Sweep database: ' + AdbName + ' completed');
       except
-        on e: exception do
+        on E: Exception do
         begin
-          MessageDlg('Error: ' + e.Message, mtError, [mbOK], 0);
+          MessageDlg('Error: ' + E.Message, mtError, [mbOK], 0);
         end;
       end;
       DetachService;
     end;
   finally
+    Screen.Cursor:= crDefault;
     FireBirdServices.Free;
   end;
 end;
@@ -3537,6 +3540,18 @@ begin
   end;
 end;
 
+procedure TfmMain.lmRecalculateStatisticsClick(Sender: TObject);
+begin
+  //Recalculate index statistics. May take a while for big dbs.
+  Screen.Cursor:= crSQLWait;
+  try
+    dmSysTables.RecalculateIndexStatistics(PtrInt(tvMain.Selected.Data));
+  finally
+    Screen.Cursor:= crDefault;
+  end;
+  ShowMessage('Recalculation of index statistics complete.');
+end;
+
 (********  Create new database  ********)
 
 procedure TfmMain.mnCreateDBClick(Sender: TObject);

scriptdb.pas

@@ -9,6 +9,9 @@ uses
   Classes, SysUtils, turbocommon, dialogs;
 
 
+// Scripts all roles; changes List to contain the CREATE ROLE SQL statements
+// Will deal with existing RDB$ADMIN role (FB 2.5+ has this present by default;
+// earlier db versions do not)
 function ScriptAllRoles(dbIndex: Integer; var List: TStringList): Boolean;
 // Scripts all UDF functions in a database
 function ScriptAllFunctions(dbIndex: Integer; var List: TStringList): Boolean;
@@ -70,18 +73,50 @@ end;
 (********************  Script Roles  ***********************)
 
 function ScriptAllRoles(dbIndex: Integer; var List: TStringList): Boolean;
+const
+  AdminRole= 'RDB$ADMIN';
 var
   Count: Integer;
+  HasRDBAdmin: boolean;
   i: Integer;
 begin
+  HasRDBAdmin:= false;
   List.CommaText:= dmSysTables.GetDBObjectNames(dbIndex, otRoles, Count);
-  { todo: (low priority) wrap create role RDB$Admin statement - in FB 2.5+ this role is present
+  { Wwrap creates role RDB$Admin statement - in FB 2.5+ this role is present
   by default, in lower dbs it isn't. No way to find out in advance when writing
-  a script. No support in FB yet for CREATE OR UPDATE ROLE so probably best
-  to do it in execute block with error handling or
-  first check system tables for role existence, again with execute block }
-  for i:= 0 to List.Count - 1 do
-    List[i]:= 'Create Role ' + List[i] + ';';
+  a script. No support in FB yet for CREATE OR UPDATE ROLE so best
+  to do it in execute block with error handling }
+  i:= 0;
+  while i<List.Count do
+  begin
+    if uppercase(List[i]) = AdminRole then
+    begin
+      // Delete now; recreate at beginning with line endings
+      HasRDBAdmin:= true;
+      List.Delete(i);
+    end
+    else
+    begin
+      // Normal role
+      List[i]:= 'Create Role ' + List[i] + ';';
+      inc(i);
+    end;
+  end;
+  if HasRDBAdmin then
+  begin
+    // Insert special role at beginning for easy editing
+    List.Insert(0, '-- use set term for isql etc. Needs to be changed for FlameRobin etc.');
+    List.Insert(1, 'set term !! ;'); //temporarily change terminator
+    List.Insert(2, 'Execute block As ');
+    List.Insert(3, 'Begin ');
+    List.Insert(4, '  Execute statement ''Create Role ' + AdminRole + ';''; ');
+    List.Insert(5, '  When any do ');
+    List.Insert(6, '  begin ');
+    List.Insert(7, '    -- ignore errors creating role (e.g. if it already exists) ');
+    List.Insert(8, '  end ');
+    List.Insert(9, 'End!! '); //closes block using changed terminator
+    List.Insert(10, 'set term ; !!');
+  end;
   Result:= List.Count > 0;
 end;
 

systables.pas

@@ -36,6 +36,12 @@ type
     // Gets list of object names that have type specified by TVIndex
     // Returns count of objects in Count
     function GetDBObjectNames(DatabaseIndex: integer; ObjectType: TObjectType; var Count: Integer): string;
+
+    // Recalculates index statistics for all fields in database
+    // Useful when a large amount of inserts/deletes may have changed the statistics
+    // and indexes are not as efficient as they could be.
+    function RecalculateIndexStatistics(dbIndex: integer): boolean;
+
     // Returns object list (list of object names, i.e. tables, views) sorted by dependency
     // Limits sorting within one category (e.g. views)
     procedure SortDependencies(var ObjectList: TStringList);
@@ -95,9 +101,11 @@ type
       var ODSVerMajor, ODSVerMinor, Pages, PageSize: Integer;
       var ProcessList: TStringList; var ErrorMsg: string): Boolean;
 
+    // Gets index info for a certain database+table
     function GetIndices(dbIndex: Integer; ATableName: string; PrimaryIndexName: string;
       var List: TStringList): Boolean;
 
+    // Gets all index info for a certain database
     function GetAllIndices(dbIndex: Integer; List, TablesList: TStringList): Boolean;
 
     function GetPrimaryKeyIndexName(dbIndex: Integer; ATableName: string; var ConstraintName: string): string;
@@ -213,6 +221,48 @@ begin
   sqQuery.Close;
 end;
 
+function TdmSysTables.RecalculateIndexStatistics(dbIndex: integer): boolean;
+var
+  i: integer;
+  Indices, Tables: TStringList;
+  TransActive: boolean;
+begin
+  result:= false;
+  Init(dbIndex);
+  sqQuery.Close;
+  Indices:= TStringList.Create;
+  Tables:= TStringList.Create;
+  try
+    if not(GetAllIndices(dbIndex, Indices, Tables)) then
+    begin
+      {$IFDEF DEBUG}
+      SendDebug('RecalculateIndexStatistics: GetAllIndices call failed.');
+      {$ENDIF}
+      exit(false);
+    end;
+
+    // Loop through all indices and reset statistics
+    TransActive:= stTrans.Active;
+    if (TransActive) then
+      stTrans.Commit;
+    for i:= 0 to Indices.Count-1 do
+    begin
+      stTrans.StartTransaction;
+      sqQuery.SQL.Text:= format('SET statistics INDEX %s',[Indices[i]]);
+      sqQuery.ExecSQL;
+      { Commit after each index; no need to batch it all up in one
+      big atomic transaction...}
+      stTrans.Commit;
+    end;
+    if TransActive then
+      stTrans.StartTransaction; //leave transaction the way we found it
+  finally
+    Indices.Free;
+    Tables.Free;
+  end;
+  result:= true;
+end;
+
 procedure TdmSysTables.SortDependencies(var ObjectList: TStringList);
 const
   QueryTemplate=
@@ -1039,9 +1089,9 @@ begin
     sqQuery.Close;
     Result:= True;
   except
-    on e: exception do
+    on E: Exception do
     begin
-      ErrorMsg:= e.Message;
+      ErrorMsg:= E.Message;
       Result:= False;
     end;
   end;
@@ -1067,15 +1117,17 @@ begin
     end;
   end;
   sqQuery.Close
-
 end;
 
 function TdmSysTables.GetAllIndices(dbIndex: Integer; List, TablesList: TStringList): Boolean;
+const
+  SQL = 'SELECT * FROM RDB$INDICES ' +
+    'WHERE RDB$FOREIGN_KEY IS NULL ' +
+    'and RDB$system_flag = 0';
 begin
   Init(dbIndex);
   sqQuery.Close;
-  sqQuery.SQL.Text:= 'SELECT * FROM RDB$INDICES WHERE  RDB$FOREIGN_KEY IS NULL ' +
-   'and RDB$system_flag = 0';
+  sqQuery.SQL.Text:= SQL;
   sqQuery.Open;
   Result:= sqQuery.RecordCount > 0;
   List.Clear;