Prechádzať zdrojové kódy

Fix: GameCube controller adapter hotplug not working

SDL_PrivateJoystickAdded was called before setting the InstanceId in the adapters ctx->joysticks array.  This would eventually broadcast the SDL_EVENT_JOYSTICK_ADDED event with the new InstanceId, if your program listens for the added events and opens joysticks at that point it would always fail because there would be no matching InstanceId in the ctx->joysticks array.

(cherry picked from commit afd1e5102321cfa3c8e0798bbee159452f51ef4d)
Joe [ReRezd] 3 mesiacov pred
rodič
commit
49e9134774
1 zmenil súbory, kde vykonal 3 pridanie a 2 odobranie
  1. 3 2
      src/joystick/hidapi/SDL_hidapijoystick.c

+ 3 - 2
src/joystick/hidapi/SDL_hidapijoystick.c

@@ -751,11 +751,12 @@ bool HIDAPI_JoystickConnected(SDL_HIDAPI_Device *device, SDL_JoystickID *pJoysti
 
     ++SDL_HIDAPI_numjoysticks;
 
-    SDL_PrivateJoystickAdded(joystickID);
-
     if (pJoystickID) {
         *pJoystickID = joystickID;
     }
+
+    SDL_PrivateJoystickAdded(joystickID);
+
     return true;
 }