瀏覽代碼

Add missing null check for displaydata during window creation

Found in the wild from minidump reports. Unclear displaydata is null, but according
to the API it is possible for this call to return null so it seems like a valid check.
Sam Lantinga 1 年之前
父節點
當前提交
6664a089d8
共有 1 個文件被更改,包括 4 次插入0 次删除
  1. 4 0
      src/video/x11/SDL_x11window.c

+ 4 - 0
src/video/x11/SDL_x11window.c

@@ -446,6 +446,10 @@ int X11_CreateWindow(SDL_VideoDevice *_this, SDL_Window *window, SDL_PropertiesI
 
     SDL_VideoData *data = _this->driverdata;
     SDL_DisplayData *displaydata = SDL_GetDisplayDriverDataForWindow(window);
+    if (!displaydata) {
+        return SDL_SetError("Could not find display info");
+    }
+
     const SDL_bool force_override_redirect = SDL_GetHintBoolean(SDL_HINT_X11_FORCE_OVERRIDE_REDIRECT, SDL_FALSE);
     SDL_WindowData *windowdata;
     Display *display = data->display;