浏览代码

Static analysis fix: leaking Objective-C object.

Ryan C. Gordon 11 年之前
父节点
当前提交
a25bd63cc5
共有 1 个文件被更改,包括 8 次插入2 次删除
  1. 8 2
      src/video/cocoa/SDL_cocoaevents.m

+ 8 - 2
src/video/cocoa/SDL_cocoaevents.m

@@ -159,13 +159,19 @@ CreateApplicationMenus(void)
     NSMenu *windowMenu;
     NSMenu *viewMenu;
     NSMenuItem *menuItem;
+    NSMenu *mainMenu;
 
     if (NSApp == nil) {
         return;
     }
-    
+
+    mainMenu = [[NSMenu alloc] init];
+
     /* Create the main menu bar */
-    [NSApp setMainMenu:[[NSMenu alloc] init]];
+    [NSApp setMainMenu:mainMenu];
+
+    [mainMenu release];  /* we're done with it, let NSApp own it. */
+    mainMenu = nil;
 
     /* Create the application menu */
     appName = GetApplicationName();