Quellcode durchsuchen

Merge pull request #4963 from avaneyev/fix-fbx-document-duplicate-id-leak

Fix a leak in FBXDocument when duplicate object IDs are found
Kim Kulling vor 2 Jahren
Ursprung
Commit
46ae8534f7
1 geänderte Dateien mit 3 neuen und 1 gelöschten Zeilen
  1. 3 1
      code/AssetLib/FBX/FBXDocument.cpp

+ 3 - 1
code/AssetLib/FBX/FBXDocument.cpp

@@ -381,8 +381,10 @@ void Document::ReadObjects() {
             DOMError("encountered object with implicitly defined id 0",el.second);
         }
 
-        if(objects.find(id) != objects.end()) {
+        const auto foundObject = objects.find(id);
+        if(foundObject != objects.end()) {
             DOMWarning("encountered duplicate object id, ignoring first occurrence",el.second);
+            delete foundObject->second;
         }
 
         objects[id] = new LazyObject(id, *el.second, *this);