Explorar o código

Fix infinite loop in STL loader

If next character was not part of valid token and not whitespace we
would end up spinning in the loop indefinitely. Fix by using do..while
loop which always skips at least one character.

Fixes testcase hangs/73b42cd3b6d05e2ddb5c0fe5888459bc
Turo Lamminen %!s(int64=10) %!d(string=hai) anos
pai
achega
6b9f9afd7a
Modificáronse 1 ficheiros con 4 adicións e 2 borrados
  1. 4 2
      code/STLLoader.cpp

+ 4 - 2
code/STLLoader.cpp

@@ -326,8 +326,10 @@ void STLImporter::LoadASCIIFile()
 			break;
 		}
 		// else skip the whole identifier
-		else while (!::IsSpaceOrNewLine(*sz)) {
-			++sz;
+		else {
+			do {
+				++sz;
+			} while (!::IsSpaceOrNewLine(*sz));
 		}
 	}