Selaa lähdekoodia

Merge pull request #3992 from AdrianAtGoogle/gltf_fixes

Fix issues encountered during integration attempt
Kim Kulling 4 vuotta sitten
vanhempi
commit
a96e7e6e2b
2 muutettua tiedostoa jossa 5 lisäystä ja 5 poistoa
  1. 3 3
      code/AssetLib/glTF/glTFCommon.h
  2. 2 2
      code/AssetLib/glTF2/glTF2Asset.inl

+ 3 - 3
code/AssetLib/glTF/glTFCommon.h

@@ -195,11 +195,11 @@ inline void CopyValue(const glTFCommon::mat4 &v, aiMatrix4x4 &o) {
 inline std::string getCurrentAssetDir(const std::string &pFile) {
     std::string path = pFile;
     int pos = std::max(int(pFile.rfind('/')), int(pFile.rfind('\\')));
-    if (pos != int(std::string::npos)) {
-        path = pFile.substr(0, pos + 1);
+    if (pos == int(std::string::npos)) {
+        return "";
     }
 
-    return path;
+    return pFile.substr(0, pos + 1);
 }
 #if _MSC_VER
 #    pragma warning(pop)

+ 2 - 2
code/AssetLib/glTF2/glTF2Asset.inl

@@ -965,9 +965,9 @@ inline void Accessor::Read(Value &obj, Asset &r) {
     componentType = MemberOrDefault(obj, "componentType", ComponentType_BYTE);
     {
         const Value* countValue = FindUInt(obj, "count");
-        if (!countValue || countValue->GetUint() < 1)
+        if (!countValue)
         {
-            throw DeadlyImportError("A strictly positive count value is required, when reading ", id.c_str(), name.empty() ? "" : " (" + name + ")");
+            throw DeadlyImportError("A count value is required, when reading ", id.c_str(), name.empty() ? "" : " (" + name + ")");
         }
         count = countValue->GetUint();
     }