Browse Source

fix: follow-mode tweaks (#7443)

David Luzar 1 year ago
parent
commit
2c0929e537
2 changed files with 5 additions and 12 deletions
  1. 1 1
      excalidraw-app/collab/Collab.tsx
  2. 4 11
      packages/excalidraw/actions/actionNavigate.tsx

+ 1 - 1
excalidraw-app/collab/Collab.tsx

@@ -866,7 +866,7 @@ class Collab extends PureComponent<Props, CollabState> {
 
 
       this.portal.broadcastUserViewportBounds(
       this.portal.broadcastUserViewportBounds(
         { bounds: [x1, y1, x2, y2] },
         { bounds: [x1, y1, x2, y2] },
-        `follow_${this.portal.socket.id}`,
+        `follow@${this.portal.socket.id}`,
       );
       );
     }
     }
   };
   };

+ 4 - 11
packages/excalidraw/actions/actionNavigate.tsx

@@ -7,15 +7,8 @@ export const actionGoToCollaborator = register({
   name: "goToCollaborator",
   name: "goToCollaborator",
   viewMode: true,
   viewMode: true,
   trackEvent: { category: "collab" },
   trackEvent: { category: "collab" },
-  perform: (_elements, appState, value) => {
-    const _value = value as Collaborator;
-    const point = _value.pointer;
-
-    if (!point) {
-      return { appState, commitToHistory: false };
-    }
-
-    if (appState.userToFollow?.socketId === _value.socketId) {
+  perform: (_elements, appState, collaborator: Collaborator) => {
+    if (appState.userToFollow?.socketId === collaborator.socketId) {
       return {
       return {
         appState: {
         appState: {
           ...appState,
           ...appState,
@@ -29,8 +22,8 @@ export const actionGoToCollaborator = register({
       appState: {
       appState: {
         ...appState,
         ...appState,
         userToFollow: {
         userToFollow: {
-          socketId: _value.socketId!,
-          username: _value.username || "",
+          socketId: collaborator.socketId!,
+          username: collaborator.username || "",
         },
         },
         // Close mobile menu
         // Close mobile menu
         openMenu: appState.openMenu === "canvas" ? null : appState.openMenu,
         openMenu: appState.openMenu === "canvas" ? null : appState.openMenu,