Browse Source

fix: regression on dragging a selected frame by its name (#8924)

fix hit element check for a selected frame's name
Ryan Di 7 months ago
parent
commit
606ac6c743
1 changed files with 5 additions and 1 deletions
  1. 5 1
      packages/excalidraw/components/App.tsx

+ 5 - 1
packages/excalidraw/components/App.tsx

@@ -5085,7 +5085,11 @@ class App extends React.Component<AppProps, AppState> {
         isImageElement(element) ? 0 : this.getElementHitThreshold(),
       );
 
-      return isPointInShape(pointFrom(x, y), selectionShape);
+      // if hitting the bounding box, return early
+      // but if not, we should check for other cases as well (e.g. frame name)
+      if (isPointInShape(pointFrom(x, y), selectionShape)) {
+        return true;
+      }
     }
 
     // take bound text element into consideration for hit collision as well