Browse Source

[skip ci] No binding for properties panel movement and angle

Signed-off-by: Mark Tolmacs <[email protected]>
Mark Tolmacs 5 months ago
parent
commit
76a782bd52

+ 1 - 4
packages/excalidraw/components/Stats/Angle.tsx

@@ -12,7 +12,7 @@ import type { ExcalidrawElement } from "@excalidraw/element/types";
 import { angleIcon } from "../icons";
 import { angleIcon } from "../icons";
 
 
 import DragInput from "./DragInput";
 import DragInput from "./DragInput";
-import { getStepSizedValue, isPropertyEditable, updateBindings } from "./utils";
+import { getStepSizedValue, isPropertyEditable } from "./utils";
 
 
 import type { DragInputCallbackType } from "./DragInput";
 import type { DragInputCallbackType } from "./DragInput";
 import type Scene from "../../scene/Scene";
 import type Scene from "../../scene/Scene";
@@ -35,7 +35,6 @@ const handleDegreeChange: DragInputCallbackType<AngleProps["property"]> = ({
   scene,
   scene,
 }) => {
 }) => {
   const elementsMap = scene.getNonDeletedElementsMap();
   const elementsMap = scene.getNonDeletedElementsMap();
-  const elements = scene.getNonDeletedElements();
   const origElement = originalElements[0];
   const origElement = originalElements[0];
   if (origElement && !isElbowArrow(origElement)) {
   if (origElement && !isElbowArrow(origElement)) {
     const latestElement = elementsMap.get(origElement.id);
     const latestElement = elementsMap.get(origElement.id);
@@ -48,7 +47,6 @@ const handleDegreeChange: DragInputCallbackType<AngleProps["property"]> = ({
       mutateElement(latestElement, {
       mutateElement(latestElement, {
         angle: nextAngle,
         angle: nextAngle,
       });
       });
-      updateBindings(latestElement, elementsMap, elements, scene);
 
 
       const boundTextElement = getBoundTextElement(latestElement, elementsMap);
       const boundTextElement = getBoundTextElement(latestElement, elementsMap);
       if (boundTextElement && !isArrowElement(latestElement)) {
       if (boundTextElement && !isArrowElement(latestElement)) {
@@ -74,7 +72,6 @@ const handleDegreeChange: DragInputCallbackType<AngleProps["property"]> = ({
     mutateElement(latestElement, {
     mutateElement(latestElement, {
       angle: nextAngle,
       angle: nextAngle,
     });
     });
-    updateBindings(latestElement, elementsMap, elements, scene);
 
 
     const boundTextElement = getBoundTextElement(latestElement, elementsMap);
     const boundTextElement = getBoundTextElement(latestElement, elementsMap);
     if (boundTextElement && !isArrowElement(latestElement)) {
     if (boundTextElement && !isArrowElement(latestElement)) {

+ 0 - 32
packages/excalidraw/components/Stats/utils.ts

@@ -1,14 +1,9 @@
 import { pointFrom, pointRotateRads } from "@excalidraw/math";
 import { pointFrom, pointRotateRads } from "@excalidraw/math";
 
 
-import {
-  bindOrUnbindLinearElements,
-  updateBoundElements,
-} from "@excalidraw/element/binding";
 import { mutateElement } from "@excalidraw/element/mutateElement";
 import { mutateElement } from "@excalidraw/element/mutateElement";
 import { getBoundTextElement } from "@excalidraw/element/textElement";
 import { getBoundTextElement } from "@excalidraw/element/textElement";
 import {
 import {
   isFrameLikeElement,
   isFrameLikeElement,
-  isLinearElement,
   isTextElement,
   isTextElement,
 } from "@excalidraw/element/typeChecks";
 } from "@excalidraw/element/typeChecks";
 
 
@@ -156,7 +151,6 @@ export const moveElement = (
     },
     },
     shouldInformMutation,
     shouldInformMutation,
   );
   );
-  updateBindings(latestElement, elementsMap, elements, scene);
 
 
   const boundTextElement = getBoundTextElement(
   const boundTextElement = getBoundTextElement(
     originalElement,
     originalElement,
@@ -196,29 +190,3 @@ export const getAtomicUnits = (
     });
     });
   return _atomicUnits;
   return _atomicUnits;
 };
 };
-
-export const updateBindings = (
-  latestElement: ExcalidrawElement,
-  elementsMap: NonDeletedSceneElementsMap,
-  elements: readonly NonDeletedExcalidrawElement[],
-  scene: Scene,
-  options?: {
-    simultaneouslyUpdated?: readonly ExcalidrawElement[];
-    newSize?: { width: number; height: number };
-    zoom?: AppState["zoom"];
-  },
-) => {
-  if (isLinearElement(latestElement)) {
-    bindOrUnbindLinearElements(
-      [latestElement],
-      elementsMap,
-      elements,
-      scene,
-      true,
-      [],
-      options?.zoom,
-    );
-  } else {
-    updateBoundElements(latestElement, elementsMap, options);
-  }
-};