Browse Source

[skip ci] Binding refactor

Mark Tolmacs 5 months ago
parent
commit
ce10087edc
1 changed files with 9 additions and 19 deletions
  1. 9 19
      packages/element/src/binding.ts

+ 9 - 19
packages/element/src/binding.ts

@@ -223,13 +223,17 @@ const bindOrUnbindLinearElementEdge = (
   }
   }
 };
 };
 
 
-const getOriginalBindingIfStillCloseOfLinearElementEdge = (
+const getOriginalBindingsIfStillCloseToArrowEnds = (
   linearElement: NonDeleted<ExcalidrawLinearElement>,
   linearElement: NonDeleted<ExcalidrawLinearElement>,
-  edge: "start" | "end",
   elementsMap: NonDeletedSceneElementsMap,
   elementsMap: NonDeletedSceneElementsMap,
   zoom?: AppState["zoom"],
   zoom?: AppState["zoom"],
-): NonDeleted<ExcalidrawElement> | null => {
-  const coors = getLinearElementEdgeCoors(linearElement, edge, elementsMap);
+): (NonDeleted<ExcalidrawElement> | null)[] =>
+  ["start", "end"].map((edge) => {
+    const coors = getLinearElementEdgeCoors(
+      linearElement,
+      edge as "start" | "end",
+      elementsMap,
+    );
   const elementId =
   const elementId =
     edge === "start"
     edge === "start"
       ? linearElement.startBinding?.elementId
       ? linearElement.startBinding?.elementId
@@ -245,21 +249,7 @@ const getOriginalBindingIfStillCloseOfLinearElementEdge = (
   }
   }
 
 
   return null;
   return null;
-};
-
-const getOriginalBindingsIfStillCloseToArrowEnds = (
-  linearElement: NonDeleted<ExcalidrawLinearElement>,
-  elementsMap: NonDeletedSceneElementsMap,
-  zoom?: AppState["zoom"],
-): (NonDeleted<ExcalidrawElement> | null)[] =>
-  ["start", "end"].map((edge) =>
-    getOriginalBindingIfStillCloseOfLinearElementEdge(
-      linearElement,
-      edge as "start" | "end",
-      elementsMap,
-      zoom,
-    ),
-  );
+  });
 
 
 const getBindingStrategyForDraggingArrowEndpoints = (
 const getBindingStrategyForDraggingArrowEndpoints = (
   selectedElement: NonDeleted<ExcalidrawLinearElement>,
   selectedElement: NonDeleted<ExcalidrawLinearElement>,