zxing-cpp: Improve 2.3.0 version build (#6367)

* zxing-cpp: Improve 2.3.0 version build

* Fix `NDEBUG`

* Fix again

packages/z/zxing-cpp/xmake.lua

@@ -4,11 +4,14 @@ package("zxing-cpp")
     set_license("Apache-2.0")
 
     add_urls("https://github.com/zxing-cpp/zxing-cpp/archive/refs/tags/$(version).tar.gz",
-             "https://github.com/zxing-cpp/zxing-cpp.git")
+             "https://github.com/zxing-cpp/zxing-cpp.git", {submodules = false})
 
     add_versions("v2.3.0", "64e4139103fdbc57752698ee15b5f0b0f7af9a0331ecbdc492047e0772c417ba")
     add_versions("v2.2.1", "02078ae15f19f9d423a441f205b1d1bee32349ddda7467e2c84e8f08876f8635")
 
+    add_configs("reader", {description = "Build with reader support (decoders)", default = true, type = "boolean"})
+    -- Build old and new (require zint) encoder
+    add_configs("writer", {description = "Build with old and/or new writer (encoder) backend", default = true, type = "boolean"})
     add_configs("c_api", {description = "Build C API", default = false, type = "boolean"})
     add_configs("experimental", {description = "Build with experimental API", default = false, type = "boolean"})
 
@@ -18,33 +21,77 @@ package("zxing-cpp")
 
     add_deps("cmake")
 
+    on_load(function (package)
+        if package:config("c_api") or package:config("writer") then
+            if is_subhost("windows") then
+                package:add("deps", "pkgconf")
+            else
+                package:add("deps", "pkg-config")
+            end
+
+            if package:config("c_api") then
+                package:add("deps", "stb")
+            end
+            if package:config("writer") then
+                package:add("deps", "zint")
+            end
+        end
+    end)
+
     on_install(function (package)
-        local configs = {"-DBUILD_EXAMPLES=OFF", "-DBUILD_C_API=OFF", "-DBUILD_DEPENDENCIES=LOCAL"}
+        if package:config("writer") then
+            local zint = package:dep("zint")
+            if not zint:config("shared") then
+                io.replace("core/CMakeLists.txt",
+                    "target_link_libraries (ZXing PRIVATE zint)",
+                    "target_link_libraries (ZXing PRIVATE zint::zint-static)", {plain = true})
+            end
+        end
+
+        local configs = {
+            "-DBUILD_EXAMPLES=OFF",
+            "-DBUILD_C_API=OFF",
+            "-DBUILD_DEPENDENCIES=LOCAL",
+            -- >=2.3.0
+            "-DZXING_USE_BUNDLED_ZINT=OFF",
+            "-DZXING_EXAMPLES=OFF",
+            "-DZXING_DEPENDENCIES=LOCAL",
+        }
         table.insert(configs, "-DCMAKE_BUILD_TYPE=" .. (package:is_debug() and "Debug" or "Release"))
         table.insert(configs, "-DBUILD_SHARED_LIBS=" .. (package:config("shared") and "ON" or "OFF"))
+
+        table.insert(configs, "-DZXING_READERS=" .. (package:config("reader") and "ON" or "OFF"))
+        table.insert(configs, "-DZXING_WRITERS=" .. (package:config("writer") and "BOTH" or "OFF"))
         table.insert(configs, "-DBUILD_EXPERIMENTAL_API=" .. (package:config("experimental") and "ON" or "OFF"))
+        table.insert(configs, "-DZXING_EXPERIMENTAL_API=" .. (package:config("experimental") and "ON" or "OFF"))
+        table.insert(configs, "-DZXING_C_API=" .. (package:config("c_api") and "ON" or "OFF"))
 
-        local cxflags = {}
-        if package:is_plat("windows") then
-            cxflags = table.wrap(package:config("cxflags"))
-            table.insert(cxflags, "/utf-8")
+        local opt = {cxflags = {}}
+        if package:has_tool("cxx", "cl") then
+            table.insert(opt.cxflags, "/utf-8")
         end
-        import("package.tools.cmake").install(package, configs, {cxflags = cxflags})
+        if package:version() and package:version():le("2.3.0") and not package:is_debug() then
+            -- https://github.com/zxing-cpp/zxing-cpp/issues/900
+            table.insert(opt.cxflags, "-DNDEBUG")
+        end
+        import("package.tools.cmake").install(package, configs, opt)
 
-        if package:config("c_api") then
-            io.writefile("xmake.lua", [[
-                add_rules("mode.debug", "mode.release")
-                set_languages("c++17")
-                target("ZXing-c")
-                    set_kind("$(kind)")
-                    add_files("wrappers/c/zxing-c.cpp")
-                    add_headerfiles("wrappers/c/zxing-c.h", {prefixdir = "ZXing"})
-                    add_includedirs("core/src")
-                    if is_plat("windows") and is_kind("shared") then
-                        add_rules("utils.symbols.export_all", {export_classes = true})
-                    end
-            ]])
-            import("package.tools.xmake").install(package)
+        if package:version() and package:version():lt("2.3.0") then
+            if package:config("c_api") then
+                io.writefile("xmake.lua", [[
+                    add_rules("mode.debug", "mode.release")
+                    set_languages("c++17")
+                    target("ZXing-c")
+                        set_kind("$(kind)")
+                        add_files("wrappers/c/zxing-c.cpp")
+                        add_headerfiles("wrappers/c/zxing-c.h", {prefixdir = "ZXing"})
+                        add_includedirs("core/src")
+                        if is_plat("windows") and is_kind("shared") then
+                            add_rules("utils.symbols.export_all", {export_classes = true})
+                        end
+                ]])
+                import("package.tools.xmake").install(package)
+            end
         end
     end)
 
@@ -59,6 +106,10 @@ package("zxing-cpp")
         ]]}, {configs = {languages = "c++17"}}))
 
         if package:config("c_api") then
-            assert(package:has_cfuncs("zxing_ImageView_new", {includes = "ZXing/zxing-c.h"}))
+            if package:version() and package:version():ge("2.3.0") then
+                assert(package:has_cfuncs("ZXing_ImageView_new", {includes = "ZXing/ZXingC.h"}))
+            else
+                assert(package:has_cfuncs("zxing_ImageView_new", {includes = "ZXing/zxing-c.h"}))
+            end
         end
     end)