Browse Source

Merge pull request #22841 from J08nY/fix/collision-object-macro

Fix multi-statement macro call not being covered.
Rémi Verschelde 7 years ago
parent
commit
0063ba9207
2 changed files with 6 additions and 4 deletions
  1. 4 3
      modules/bullet/bullet_utilities.h
  2. 2 1
      modules/bullet/collision_object_bullet.cpp

+ 4 - 3
modules/bullet/bullet_utilities.h

@@ -39,7 +39,8 @@
 	new cl
 
 #define bulletdelete(cl) \
-	delete cl;           \
-	cl = NULL;
-
+	{                    \
+		delete cl;       \
+		cl = NULL;       \
+	}
 #endif

+ 2 - 1
modules/bullet/collision_object_bullet.cpp

@@ -310,9 +310,10 @@ void RigidCollisionObjectBullet::shape_changed(int p_shape_index) {
 
 void RigidCollisionObjectBullet::reload_shapes() {
 
-	if (mainShape && mainShape->isCompound())
+	if (mainShape && mainShape->isCompound()) {
 		// Destroy compound
 		bulletdelete(mainShape);
+	}
 
 	mainShape = NULL;