Browse Source

Merge pull request #96449 from Maran23/editor-help-scroll-fix

Fix jumping to editor help does not scroll correctly sometimes
Rémi Verschelde 8 months ago
parent
commit
05b80ae0a1
2 changed files with 2 additions and 7 deletions
  1. 1 5
      editor/editor_help.cpp
  2. 1 2
      editor/plugins/script_editor_plugin.cpp

+ 1 - 5
editor/editor_help.cpp

@@ -2378,11 +2378,7 @@ void EditorHelp::_help_callback(const String &p_topic) {
 	}
 	}
 
 
 	if (class_desc->is_finished()) {
 	if (class_desc->is_finished()) {
-		// call_deferred() is not enough.
-		if (class_desc->is_connected(SceneStringName(draw), callable_mp(class_desc, &RichTextLabel::scroll_to_paragraph))) {
-			class_desc->disconnect(SceneStringName(draw), callable_mp(class_desc, &RichTextLabel::scroll_to_paragraph));
-		}
-		class_desc->connect(SceneStringName(draw), callable_mp(class_desc, &RichTextLabel::scroll_to_paragraph).bind(line), CONNECT_ONE_SHOT | CONNECT_DEFERRED);
+		class_desc->scroll_to_paragraph(line);
 	} else {
 	} else {
 		scroll_to = line;
 		scroll_to = line;
 	}
 	}

+ 1 - 2
editor/plugins/script_editor_plugin.cpp

@@ -3653,14 +3653,13 @@ void ScriptEditor::_help_class_goto(const String &p_desc) {
 
 
 	eh->set_name(cname);
 	eh->set_name(cname);
 	tab_container->add_child(eh);
 	tab_container->add_child(eh);
+	_go_to_tab(tab_container->get_tab_count() - 1);
 	eh->go_to_help(p_desc);
 	eh->go_to_help(p_desc);
 	eh->connect("go_to_help", callable_mp(this, &ScriptEditor::_help_class_goto));
 	eh->connect("go_to_help", callable_mp(this, &ScriptEditor::_help_class_goto));
 	_add_recent_script(eh->get_class());
 	_add_recent_script(eh->get_class());
 	_sort_list_on_update = true;
 	_sort_list_on_update = true;
 	_update_script_names();
 	_update_script_names();
 	_save_layout();
 	_save_layout();
-
-	callable_mp(this, &ScriptEditor::_help_tab_goto).call_deferred(cname, p_desc);
 }
 }
 
 
 bool ScriptEditor::_help_tab_goto(const String &p_name, const String &p_desc) {
 bool ScriptEditor::_help_tab_goto(const String &p_name, const String &p_desc) {