Browse Source

Merge pull request #68564 from Mickeon/node-no-remove-group-error

Strip ERR_FAIL from `Node.remove_from_group()`
Rémi Verschelde 2 years ago
parent
commit
0dbb632116
2 changed files with 4 additions and 4 deletions
  1. 1 1
      doc/classes/Node.xml
  2. 3 3
      scene/main/node.cpp

+ 1 - 1
doc/classes/Node.xml

@@ -606,7 +606,7 @@
 			<return type="void" />
 			<param index="0" name="group" type="StringName" />
 			<description>
-				Removes a node from a group. See notes in the description, and the group methods in [SceneTree].
+				Removes a node from the [param group]. Does nothing if the node is not in the [param group]. See notes in the description, and the group methods in [SceneTree].
 			</description>
 		</method>
 		<method name="replace_by">

+ 3 - 3
scene/main/node.cpp

@@ -1759,11 +1759,11 @@ void Node::add_to_group(const StringName &p_identifier, bool p_persistent) {
 }
 
 void Node::remove_from_group(const StringName &p_identifier) {
-	ERR_FAIL_COND(!data.grouped.has(p_identifier));
-
 	HashMap<StringName, GroupData>::Iterator E = data.grouped.find(p_identifier);
 
-	ERR_FAIL_COND(!E);
+	if (!E) {
+		return;
+	}
 
 	if (data.tree) {
 		data.tree->remove_from_group(E->key, this);