Browse Source

EditorSettings: Remove enable_code_completion_delay

It was badly named (it disables code completion, not just the delay), and also
badly implemented (not preventing the timer for running, but just preventing it
to show the autocompletion).

It could be readded with a proper name and cleaner implementation if there's an
actual need for it.

Supersedes #24407 and closes #24352.
Rémi Verschelde 6 năm trước cách đây
mục cha
commit
1039ba9ffb
1 tập tin đã thay đổi với 1 bổ sung6 xóa
  1. 1 6
      editor/code_editor.cpp

+ 1 - 6
editor/code_editor.cpp

@@ -708,8 +708,7 @@ void CodeTextEditor::_text_changed() {
 void CodeTextEditor::_code_complete_timer_timeout() {
 	if (!is_visible_in_tree())
 		return;
-	if (enable_complete_timer)
-		text_editor->query_code_comple();
+	text_editor->query_code_comple();
 }
 
 void CodeTextEditor::_complete_request() {
@@ -1172,8 +1171,6 @@ void CodeTextEditor::_on_settings_change() {
 	code_complete_timer->set_wait_time(
 			EDITOR_DEF("text_editor/completion/code_complete_delay", .3f));
 
-	enable_complete_timer = EDITOR_DEF("text_editor/completion/enable_code_completion_delay", true);
-
 	// call hint settings
 	text_editor->set_callhint_settings(
 			EDITOR_DEF("text_editor/completion/put_callhint_tooltip_below_current_line", true),
@@ -1252,8 +1249,6 @@ CodeTextEditor::CodeTextEditor() {
 	code_complete_timer = memnew(Timer);
 	add_child(code_complete_timer);
 	code_complete_timer->set_one_shot(true);
-	enable_complete_timer = EDITOR_DEF("text_editor/completion/enable_code_completion_delay", true);
-
 	code_complete_timer->set_wait_time(EDITOR_DEF("text_editor/completion/code_complete_delay", .3f));
 
 	error_line = 0;