Explorar o código

Merge pull request #96383 from dsnopek/gdextension-pdb-missing-error

GDExtension: Show warning on missing PDB file, rather than error
Rémi Verschelde hai 1 ano
pai
achega
109fafc7a4
Modificáronse 1 ficheiros con 5 adicións e 1 borrados
  1. 5 1
      platform/windows/windows_utils.cpp

+ 5 - 1
platform/windows/windows_utils.cpp

@@ -155,7 +155,11 @@ Error WindowsUtils::copy_and_rename_pdb(const String &p_dll_path) {
 	} else if (!FileAccess::exists(copy_pdb_path)) {
 		copy_pdb_path = dll_base_dir.path_join(copy_pdb_path.get_file());
 	}
-	ERR_FAIL_COND_V_MSG(!FileAccess::exists(copy_pdb_path), FAILED, vformat("File '%s' does not exist.", copy_pdb_path));
+	if (!FileAccess::exists(copy_pdb_path)) {
+		// The PDB file may be distributed separately on purpose, so we don't consider this an error.
+		WARN_VERBOSE(vformat("PDB file '%s' for library '%s' was not found, skipping copy/rename.", copy_pdb_path, p_dll_path));
+		return ERR_SKIP;
+	}
 
 	String new_pdb_base_name = p_dll_path.get_file().get_basename() + "_";