Browse Source

NoiseTexture: prevent race condition because of Ref::unref()

lupoDharkael 5 years ago
parent
commit
1f0f0b8cea
1 changed files with 8 additions and 3 deletions
  1. 8 3
      modules/opensimplex/noise_texture.cpp

+ 8 - 3
modules/opensimplex/noise_texture.cpp

@@ -137,14 +137,19 @@ void NoiseTexture::_queue_update() {
 
 Ref<Image> NoiseTexture::_generate_texture() {
 
-	if (noise.is_null()) return Ref<Image>();
+	// Prevent memdelete due to unref() on other thread.
+	Ref<OpenSimplexNoise> ref_noise = noise;
+
+	if (ref_noise.is_null()) {
+		return Ref<Image>();
+	}
 
 	Ref<Image> image;
 
 	if (seamless) {
-		image = noise->get_seamless_image(size.x);
+		image = ref_noise->get_seamless_image(size.x);
 	} else {
-		image = noise->get_image(size.x, size.y);
+		image = ref_noise->get_image(size.x, size.y);
 	}
 
 	if (as_normalmap) {