Przeglądaj źródła

Merge pull request #96666 from aXu-AP/unique-node-no-quotes

Remove unneeded quotes from autocomplete % nodes
Rémi Verschelde 1 rok temu
rodzic
commit
1ff2186fe9

+ 2 - 2
modules/gdscript/gdscript_editor.cpp

@@ -3486,10 +3486,10 @@ static void _find_call_arguments(GDScriptParser::CompletionContext &p_context, c
 						opt = opt.substr(1);
 					}
 
-					// The path needs quotes if at least one of its components (excluding `/` separations)
+					// The path needs quotes if at least one of its components (excluding `%` prefix and `/` separations)
 					// is not a valid identifier.
 					bool path_needs_quote = false;
-					for (const String &part : opt.split("/")) {
+					for (const String &part : opt.trim_prefix("%").split("/")) {
 						if (!part.is_valid_ascii_identifier()) {
 							path_needs_quote = true;
 							break;

+ 9 - 0
modules/gdscript/tests/scripts/completion/get_node/literal_scene/dollar_unique.cfg

@@ -0,0 +1,9 @@
+[input]
+scene="res://completion/get_node/get_node.tscn"
+[output]
+include=[
+    {"display": "%UniqueA"},
+]
+exclude=[
+    {"display": "\"%UniqueA\""},
+]

+ 5 - 0
modules/gdscript/tests/scripts/completion/get_node/literal_scene/dollar_unique.gd

@@ -0,0 +1,5 @@
+extends Node
+
+func a():
+    $➡
+    pass