Browse Source

Merge pull request #24777 from volzhs/font-kerning

Fix font kerning
Rémi Verschelde 6 years ago
parent
commit
3873f84548
2 changed files with 0 additions and 17 deletions
  1. 0 16
      scene/resources/dynamic_font.cpp
  2. 0 1
      scene/resources/dynamic_font.h

+ 0 - 16
scene/resources/dynamic_font.cpp

@@ -281,18 +281,6 @@ const Pair<const DynamicFontAtSize::Character *, DynamicFontAtSize *> DynamicFon
 	return Pair<const Character *, DynamicFontAtSize *>(chr, const_cast<DynamicFontAtSize *>(this));
 	return Pair<const Character *, DynamicFontAtSize *>(chr, const_cast<DynamicFontAtSize *>(this));
 }
 }
 
 
-float DynamicFontAtSize::_get_kerning_advance(const DynamicFontAtSize *font, CharType p_char, CharType p_next) const {
-	float advance = 0.0;
-
-	if (p_next) {
-		FT_Vector delta;
-		FT_Get_Kerning(font->face, p_char, p_next, FT_KERNING_DEFAULT, &delta);
-		advance = (delta.x / 64.0) / oversampling;
-	}
-
-	return advance;
-}
-
 Size2 DynamicFontAtSize::get_char_size(CharType p_char, CharType p_next, const Vector<Ref<DynamicFontAtSize> > &p_fallbacks) const {
 Size2 DynamicFontAtSize::get_char_size(CharType p_char, CharType p_next, const Vector<Ref<DynamicFontAtSize> > &p_fallbacks) const {
 
 
 	if (!valid)
 	if (!valid)
@@ -301,7 +289,6 @@ Size2 DynamicFontAtSize::get_char_size(CharType p_char, CharType p_next, const V
 
 
 	Pair<const Character *, DynamicFontAtSize *> char_pair_with_font = _find_char_with_font(p_char, p_fallbacks);
 	Pair<const Character *, DynamicFontAtSize *> char_pair_with_font = _find_char_with_font(p_char, p_fallbacks);
 	const Character *ch = char_pair_with_font.first;
 	const Character *ch = char_pair_with_font.first;
-	DynamicFontAtSize *font = char_pair_with_font.second;
 	ERR_FAIL_COND_V(!ch, Size2());
 	ERR_FAIL_COND_V(!ch, Size2());
 
 
 	Size2 ret(0, get_height());
 	Size2 ret(0, get_height());
@@ -309,7 +296,6 @@ Size2 DynamicFontAtSize::get_char_size(CharType p_char, CharType p_next, const V
 	if (ch->found) {
 	if (ch->found) {
 		ret.x = ch->advance;
 		ret.x = ch->advance;
 	}
 	}
-	ret.x += _get_kerning_advance(font, p_char, p_next);
 
 
 	return ret;
 	return ret;
 }
 }
@@ -358,8 +344,6 @@ float DynamicFontAtSize::draw_char(RID p_canvas_item, const Point2 &p_pos, CharT
 		advance = ch->advance;
 		advance = ch->advance;
 	}
 	}
 
 
-	advance += _get_kerning_advance(font, p_char, p_next);
-
 	return advance;
 	return advance;
 }
 }
 
 

+ 0 - 1
scene/resources/dynamic_font.h

@@ -164,7 +164,6 @@ class DynamicFontAtSize : public Reference {
 
 
 	const Pair<const Character *, DynamicFontAtSize *> _find_char_with_font(CharType p_char, const Vector<Ref<DynamicFontAtSize> > &p_fallbacks) const;
 	const Pair<const Character *, DynamicFontAtSize *> _find_char_with_font(CharType p_char, const Vector<Ref<DynamicFontAtSize> > &p_fallbacks) const;
 	Character _make_outline_char(CharType p_char);
 	Character _make_outline_char(CharType p_char);
-	float _get_kerning_advance(const DynamicFontAtSize *font, CharType p_char, CharType p_next) const;
 	TexturePosition _find_texture_pos_for_glyph(int p_color_size, Image::Format p_image_format, int p_width, int p_height);
 	TexturePosition _find_texture_pos_for_glyph(int p_color_size, Image::Format p_image_format, int p_width, int p_height);
 	Character _bitmap_to_character(FT_Bitmap bitmap, int yofs, int xofs, float advance);
 	Character _bitmap_to_character(FT_Bitmap bitmap, int yofs, int xofs, float advance);