Browse Source

Fix UI navigation with joysticks

(cherry picked from commit cf788ae684966b07cd15cacad86043a4c4d14c4c)
Univeous 3 years ago
parent
commit
42e3187560
1 changed files with 46 additions and 17 deletions
  1. 46 17
      scene/main/viewport.cpp

+ 46 - 17
scene/main/viewport.cpp

@@ -2426,28 +2426,57 @@ void Viewport::_gui_input_event(Ref<InputEvent> p_event) {
 		if (from && p_event->is_pressed()) {
 			Control *next = nullptr;
 
-			if (p_event->is_action_pressed("ui_focus_next", true)) {
-				next = from->find_next_valid_focus();
-			}
+			Ref<InputEventJoypadMotion> joypadmotion_event = p_event;
+			if (joypadmotion_event.is_valid()) {
+				Input *input = Input::get_singleton();
 
-			if (p_event->is_action_pressed("ui_focus_prev", true)) {
-				next = from->find_prev_valid_focus();
-			}
+				if (p_event->is_action_pressed("ui_focus_next") && input->is_action_just_pressed("ui_focus_next")) {
+					next = from->find_next_valid_focus();
+				}
 
-			if (!mods && p_event->is_action_pressed("ui_up", true)) {
-				next = from->_get_focus_neighbour(MARGIN_TOP);
-			}
+				if (p_event->is_action_pressed("ui_focus_prev") && input->is_action_just_pressed("ui_focus_prev")) {
+					next = from->find_prev_valid_focus();
+				}
 
-			if (!mods && p_event->is_action_pressed("ui_left", true)) {
-				next = from->_get_focus_neighbour(MARGIN_LEFT);
-			}
+				if (!mods && p_event->is_action_pressed("ui_up") && input->is_action_just_pressed("ui_up")) {
+					next = from->_get_focus_neighbour(MARGIN_TOP);
+				}
 
-			if (!mods && p_event->is_action_pressed("ui_right", true)) {
-				next = from->_get_focus_neighbour(MARGIN_RIGHT);
-			}
+				if (!mods && p_event->is_action_pressed("ui_left") && input->is_action_just_pressed("ui_left")) {
+					next = from->_get_focus_neighbour(MARGIN_LEFT);
+				}
+
+				if (!mods && p_event->is_action_pressed("ui_right") && input->is_action_just_pressed("ui_right")) {
+					next = from->_get_focus_neighbour(MARGIN_RIGHT);
+				}
+
+				if (!mods && p_event->is_action_pressed("ui_down") && input->is_action_just_pressed("ui_down")) {
+					next = from->_get_focus_neighbour(MARGIN_BOTTOM);
+				}
+			} else {
+				if (p_event->is_action_pressed("ui_focus_next", true)) {
+					next = from->find_next_valid_focus();
+				}
+
+				if (p_event->is_action_pressed("ui_focus_prev", true)) {
+					next = from->find_prev_valid_focus();
+				}
+
+				if (!mods && p_event->is_action_pressed("ui_up", true)) {
+					next = from->_get_focus_neighbour(MARGIN_TOP);
+				}
+
+				if (!mods && p_event->is_action_pressed("ui_left", true)) {
+					next = from->_get_focus_neighbour(MARGIN_LEFT);
+				}
 
-			if (!mods && p_event->is_action_pressed("ui_down", true)) {
-				next = from->_get_focus_neighbour(MARGIN_BOTTOM);
+				if (!mods && p_event->is_action_pressed("ui_right", true)) {
+					next = from->_get_focus_neighbour(MARGIN_RIGHT);
+				}
+
+				if (!mods && p_event->is_action_pressed("ui_down", true)) {
+					next = from->_get_focus_neighbour(MARGIN_BOTTOM);
+				}
 			}
 
 			if (next) {