Browse Source

Merge pull request #106749 from KoBeWi/hard-coding_is_bad_for_your_health

Don't hard-code test path when deleting test data
Thaddeus Crews 2 months ago
parent
commit
45fc515ae3
1 changed files with 3 additions and 5 deletions
  1. 3 5
      tests/test_main.cpp

+ 3 - 5
tests/test_main.cpp

@@ -234,11 +234,9 @@ int test_main(int argc, char *argv[]) {
 
 	WorkerThreadPool::get_singleton()->init();
 
-	String test_path = OS::get_singleton()->get_cache_path().path_join("godot_test");
-
-	Ref<DirAccess> da;
-	if (DirAccess::exists(test_path)) {
-		da = DirAccess::open(test_path);
+	{
+		const String test_path = TestUtils::get_temp_path("");
+		Ref<DirAccess> da = DirAccess::open(test_path); // get_temp_path() automatically creates the folder.
 		ERR_FAIL_COND_V(da.is_null(), 0);
 		ERR_FAIL_COND_V_MSG(da->erase_contents_recursive() != OK, 0, "Failed to delete files");
 	}