Browse Source

Fix "p_from_line > p_to_line" errors in text edit

Done via making the function more robust to different inputs
nova++ 3 years ago
parent
commit
4b8fa3716f
1 changed files with 5 additions and 1 deletions
  1. 5 1
      scene/gui/text_edit.cpp

+ 5 - 1
scene/gui/text_edit.cpp

@@ -4469,7 +4469,11 @@ int TextEdit::get_visible_line_count() const {
 int TextEdit::get_visible_line_count_in_range(int p_from_line, int p_to_line) const {
 	ERR_FAIL_INDEX_V(p_from_line, text.size(), 0);
 	ERR_FAIL_INDEX_V(p_to_line, text.size(), 0);
-	ERR_FAIL_COND_V(p_from_line > p_to_line, 0);
+
+	// So we can handle inputs in whatever order
+	if (p_from_line > p_to_line) {
+		SWAP(p_from_line, p_to_line);
+	}
 
 	/* Returns the total number of (lines + wrapped - hidden). */
 	if (!_is_hiding_enabled() && get_line_wrapping_mode() == LineWrappingMode::LINE_WRAPPING_NONE) {