2
0
Эх сурвалжийг харах

Fixed argument names being swapped for atan2

The arguments of atan2() should be y,x instead of x,y This was just wrong since the internal atan2 already had y,x as parameters, so if you followed the autocomplete the result would just be wrong.
DualMatrix 7 жил өмнө
parent
commit
4bad2beeed

+ 1 - 1
modules/gdscript/gdscript_functions.cpp

@@ -1458,7 +1458,7 @@ MethodInfo GDScriptFunctions::get_info(Function p_func) {
 			return mi;
 			return mi;
 		} break;
 		} break;
 		case MATH_ATAN2: {
 		case MATH_ATAN2: {
-			MethodInfo mi("atan2", PropertyInfo(Variant::REAL, "x"), PropertyInfo(Variant::REAL, "y"));
+			MethodInfo mi("atan2", PropertyInfo(Variant::REAL, "y"), PropertyInfo(Variant::REAL, "x"));
 			mi.return_val.type = Variant::REAL;
 			mi.return_val.type = Variant::REAL;
 			return mi;
 			return mi;
 		} break;
 		} break;

+ 6 - 1
modules/visual_script/visual_script_builtin_funcs.cpp

@@ -260,7 +260,12 @@ PropertyInfo VisualScriptBuiltinFunc::get_input_value_port_info(int p_idx) const
 		case MATH_SQRT: {
 		case MATH_SQRT: {
 			return PropertyInfo(Variant::REAL, "s");
 			return PropertyInfo(Variant::REAL, "s");
 		} break;
 		} break;
-		case MATH_ATAN2:
+		case MATH_ATAN2: {
+			if (p_idx == 0)
+				return PropertyInfo(Variant::REAL, "y");
+			else
+				return PropertyInfo(Variant::REAL, "x");
+		} break;
 		case MATH_FMOD:
 		case MATH_FMOD:
 		case MATH_FPOSMOD: {
 		case MATH_FPOSMOD: {
 			if (p_idx == 0)
 			if (p_idx == 0)