Browse Source

Merge pull request #67939 from sambriels/emit-signal-after-target-reached

[NavigationAgent2D/3D]: target_reached signal is emitted before internal state is updated
Clay John 3 years ago
parent
commit
4dc2c8ae6f
2 changed files with 2 additions and 2 deletions
  1. 1 1
      scene/2d/navigation_agent_2d.cpp
  2. 1 1
      scene/3d/navigation_agent_3d.cpp

+ 1 - 1
scene/2d/navigation_agent_2d.cpp

@@ -478,8 +478,8 @@ void NavigationAgent2D::_request_repath() {
 void NavigationAgent2D::_check_distance_to_target() {
 	if (!target_reached) {
 		if (distance_to_target() < target_desired_distance) {
-			emit_signal(SNAME("target_reached"));
 			target_reached = true;
+			emit_signal(SNAME("target_reached"));
 		}
 	}
 }

+ 1 - 1
scene/3d/navigation_agent_3d.cpp

@@ -495,8 +495,8 @@ void NavigationAgent3D::_request_repath() {
 void NavigationAgent3D::_check_distance_to_target() {
 	if (!target_reached) {
 		if (distance_to_target() < target_desired_distance) {
-			emit_signal(SNAME("target_reached"));
 			target_reached = true;
+			emit_signal(SNAME("target_reached"));
 		}
 	}
 }