Browse Source

Made constants fully upper case in camera server

Bastiaan Olij 6 years ago
parent
commit
4ebedb5f11

+ 2 - 2
doc/classes/CameraFeed.xml

@@ -45,10 +45,10 @@
 		<constant name="FEED_RGB" value="1" enum="FeedDataType">
 		<constant name="FEED_RGB" value="1" enum="FeedDataType">
 			Feed supplies RGB images.
 			Feed supplies RGB images.
 		</constant>
 		</constant>
-		<constant name="FEED_YCbCr" value="2" enum="FeedDataType">
+		<constant name="FEED_YCBCR" value="2" enum="FeedDataType">
 			Feed supplies YCbCr images that need to be converted to RGB.
 			Feed supplies YCbCr images that need to be converted to RGB.
 		</constant>
 		</constant>
-		<constant name="FEED_YCbCr_Sep" value="3" enum="FeedDataType">
+		<constant name="FEED_YCBCR_SEP" value="3" enum="FeedDataType">
 			Feed supplies separate Y and CbCr images that need to be combined and converted to RGB.
 			Feed supplies separate Y and CbCr images that need to be combined and converted to RGB.
 		</constant>
 		</constant>
 		<constant name="FEED_UNSPECIFIED" value="0" enum="FeedPosition">
 		<constant name="FEED_UNSPECIFIED" value="0" enum="FeedPosition">

+ 2 - 2
doc/classes/CameraServer.xml

@@ -70,13 +70,13 @@
 		<constant name="FEED_RGBA_IMAGE" value="0" enum="FeedImage">
 		<constant name="FEED_RGBA_IMAGE" value="0" enum="FeedImage">
 			The RGBA camera image.
 			The RGBA camera image.
 		</constant>
 		</constant>
-		<constant name="FEED_YCbCr_IMAGE" value="0" enum="FeedImage">
+		<constant name="FEED_YCBCR_IMAGE" value="0" enum="FeedImage">
 			The YCbCr camera image.
 			The YCbCr camera image.
 		</constant>
 		</constant>
 		<constant name="FEED_Y_IMAGE" value="0" enum="FeedImage">
 		<constant name="FEED_Y_IMAGE" value="0" enum="FeedImage">
 			The Y component camera image.
 			The Y component camera image.
 		</constant>
 		</constant>
-		<constant name="FEED_CbCr_IMAGE" value="1" enum="FeedImage">
+		<constant name="FEED_CBCR_IMAGE" value="1" enum="FeedImage">
 			The CbCr component camera image.
 			The CbCr component camera image.
 		</constant>
 		</constant>
 	</constants>
 	</constants>

+ 4 - 4
drivers/gles2/rasterizer_scene_gles2.cpp

@@ -2920,16 +2920,16 @@ void RasterizerSceneGLES2::render_scene(const Transform &p_cam_transform, const
 
 
 						VS::get_singleton()->texture_bind(camera_RGBA, 0);
 						VS::get_singleton()->texture_bind(camera_RGBA, 0);
 
 
-					} else if (feed->get_datatype() == CameraFeed::FEED_YCbCr) {
-						RID camera_YCbCr = feed->get_texture(CameraServer::FEED_YCbCr_IMAGE);
+					} else if (feed->get_datatype() == CameraFeed::FEED_YCBCR) {
+						RID camera_YCbCr = feed->get_texture(CameraServer::FEED_YCBCR_IMAGE);
 
 
 						VS::get_singleton()->texture_bind(camera_YCbCr, 0);
 						VS::get_singleton()->texture_bind(camera_YCbCr, 0);
 
 
 						storage->shaders.copy.set_conditional(CopyShaderGLES2::YCBCR_TO_RGB, true);
 						storage->shaders.copy.set_conditional(CopyShaderGLES2::YCBCR_TO_RGB, true);
 
 
-					} else if (feed->get_datatype() == CameraFeed::FEED_YCbCr_Sep) {
+					} else if (feed->get_datatype() == CameraFeed::FEED_YCBCR_SEP) {
 						RID camera_Y = feed->get_texture(CameraServer::FEED_Y_IMAGE);
 						RID camera_Y = feed->get_texture(CameraServer::FEED_Y_IMAGE);
-						RID camera_CbCr = feed->get_texture(CameraServer::FEED_CbCr_IMAGE);
+						RID camera_CbCr = feed->get_texture(CameraServer::FEED_CBCR_IMAGE);
 
 
 						VS::get_singleton()->texture_bind(camera_Y, 0);
 						VS::get_singleton()->texture_bind(camera_Y, 0);
 						VS::get_singleton()->texture_bind(camera_CbCr, 1);
 						VS::get_singleton()->texture_bind(camera_CbCr, 1);

+ 4 - 4
drivers/gles3/rasterizer_scene_gles3.cpp

@@ -4454,16 +4454,16 @@ void RasterizerSceneGLES3::render_scene(const Transform &p_cam_transform, const
 						RID camera_RGBA = feed->get_texture(CameraServer::FEED_RGBA_IMAGE);
 						RID camera_RGBA = feed->get_texture(CameraServer::FEED_RGBA_IMAGE);
 
 
 						VS::get_singleton()->texture_bind(camera_RGBA, 0);
 						VS::get_singleton()->texture_bind(camera_RGBA, 0);
-					} else if (feed->get_datatype() == CameraFeed::FEED_YCbCr) {
-						RID camera_YCbCr = feed->get_texture(CameraServer::FEED_YCbCr_IMAGE);
+					} else if (feed->get_datatype() == CameraFeed::FEED_YCBCR) {
+						RID camera_YCbCr = feed->get_texture(CameraServer::FEED_YCBCR_IMAGE);
 
 
 						VS::get_singleton()->texture_bind(camera_YCbCr, 0);
 						VS::get_singleton()->texture_bind(camera_YCbCr, 0);
 
 
 						storage->shaders.copy.set_conditional(CopyShaderGLES3::YCBCR_TO_SRGB, true);
 						storage->shaders.copy.set_conditional(CopyShaderGLES3::YCBCR_TO_SRGB, true);
 
 
-					} else if (feed->get_datatype() == CameraFeed::FEED_YCbCr_Sep) {
+					} else if (feed->get_datatype() == CameraFeed::FEED_YCBCR_SEP) {
 						RID camera_Y = feed->get_texture(CameraServer::FEED_Y_IMAGE);
 						RID camera_Y = feed->get_texture(CameraServer::FEED_Y_IMAGE);
-						RID camera_CbCr = feed->get_texture(CameraServer::FEED_CbCr_IMAGE);
+						RID camera_CbCr = feed->get_texture(CameraServer::FEED_CBCR_IMAGE);
 
 
 						VS::get_singleton()->texture_bind(camera_Y, 0);
 						VS::get_singleton()->texture_bind(camera_Y, 0);
 						VS::get_singleton()->texture_bind(camera_CbCr, 1);
 						VS::get_singleton()->texture_bind(camera_CbCr, 1);

+ 9 - 9
servers/camera/camera_feed.cpp

@@ -60,8 +60,8 @@ void CameraFeed::_bind_methods() {
 
 
 	BIND_ENUM_CONSTANT(FEED_NOIMAGE);
 	BIND_ENUM_CONSTANT(FEED_NOIMAGE);
 	BIND_ENUM_CONSTANT(FEED_RGB);
 	BIND_ENUM_CONSTANT(FEED_RGB);
-	BIND_ENUM_CONSTANT(FEED_YCbCr);
-	BIND_ENUM_CONSTANT(FEED_YCbCr_Sep);
+	BIND_ENUM_CONSTANT(FEED_YCBCR);
+	BIND_ENUM_CONSTANT(FEED_YCBCR_SEP);
 
 
 	BIND_ENUM_CONSTANT(FEED_UNSPECIFIED);
 	BIND_ENUM_CONSTANT(FEED_UNSPECIFIED);
 	BIND_ENUM_CONSTANT(FEED_FRONT);
 	BIND_ENUM_CONSTANT(FEED_FRONT);
@@ -145,7 +145,7 @@ CameraFeed::CameraFeed() {
 	// create a texture object
 	// create a texture object
 	VisualServer *vs = VisualServer::get_singleton();
 	VisualServer *vs = VisualServer::get_singleton();
 	texture[CameraServer::FEED_Y_IMAGE] = vs->texture_create(); // also used for RGBA
 	texture[CameraServer::FEED_Y_IMAGE] = vs->texture_create(); // also used for RGBA
-	texture[CameraServer::FEED_CbCr_IMAGE] = vs->texture_create();
+	texture[CameraServer::FEED_CBCR_IMAGE] = vs->texture_create();
 }
 }
 
 
 CameraFeed::CameraFeed(String p_name, FeedPosition p_position) {
 CameraFeed::CameraFeed(String p_name, FeedPosition p_position) {
@@ -162,14 +162,14 @@ CameraFeed::CameraFeed(String p_name, FeedPosition p_position) {
 	// create a texture object
 	// create a texture object
 	VisualServer *vs = VisualServer::get_singleton();
 	VisualServer *vs = VisualServer::get_singleton();
 	texture[CameraServer::FEED_Y_IMAGE] = vs->texture_create(); // also used for RGBA
 	texture[CameraServer::FEED_Y_IMAGE] = vs->texture_create(); // also used for RGBA
-	texture[CameraServer::FEED_CbCr_IMAGE] = vs->texture_create();
+	texture[CameraServer::FEED_CBCR_IMAGE] = vs->texture_create();
 }
 }
 
 
 CameraFeed::~CameraFeed() {
 CameraFeed::~CameraFeed() {
 	// Free our textures
 	// Free our textures
 	VisualServer *vs = VisualServer::get_singleton();
 	VisualServer *vs = VisualServer::get_singleton();
 	vs->free(texture[CameraServer::FEED_Y_IMAGE]);
 	vs->free(texture[CameraServer::FEED_Y_IMAGE]);
-	vs->free(texture[CameraServer::FEED_CbCr_IMAGE]);
+	vs->free(texture[CameraServer::FEED_CBCR_IMAGE]);
 }
 }
 
 
 void CameraFeed::set_RGB_img(Ref<Image> p_rgb_img) {
 void CameraFeed::set_RGB_img(Ref<Image> p_rgb_img) {
@@ -208,7 +208,7 @@ void CameraFeed::set_YCbCr_img(Ref<Image> p_ycbcr_img) {
 		}
 		}
 
 
 		vs->texture_set_data(texture[CameraServer::FEED_RGBA_IMAGE], p_ycbcr_img);
 		vs->texture_set_data(texture[CameraServer::FEED_RGBA_IMAGE], p_ycbcr_img);
-		datatype = CameraFeed::FEED_YCbCr;
+		datatype = CameraFeed::FEED_YCBCR;
 	}
 	}
 }
 }
 
 
@@ -233,12 +233,12 @@ void CameraFeed::set_YCbCr_imgs(Ref<Image> p_y_img, Ref<Image> p_cbcr_img) {
 			vs->texture_allocate(texture[CameraServer::FEED_Y_IMAGE], new_y_width, new_y_height, 0, Image::FORMAT_R8, VS::TEXTURE_TYPE_2D, VS::TEXTURE_FLAG_USED_FOR_STREAMING);
 			vs->texture_allocate(texture[CameraServer::FEED_Y_IMAGE], new_y_width, new_y_height, 0, Image::FORMAT_R8, VS::TEXTURE_TYPE_2D, VS::TEXTURE_FLAG_USED_FOR_STREAMING);
 
 
 			///@TODO GLES2 doesn't support FORMAT_RG8, need to do some form of conversion
 			///@TODO GLES2 doesn't support FORMAT_RG8, need to do some form of conversion
-			vs->texture_allocate(texture[CameraServer::FEED_CbCr_IMAGE], new_cbcr_width, new_cbcr_height, 0, Image::FORMAT_RG8, VS::TEXTURE_TYPE_2D, VS::TEXTURE_FLAG_USED_FOR_STREAMING);
+			vs->texture_allocate(texture[CameraServer::FEED_CBCR_IMAGE], new_cbcr_width, new_cbcr_height, 0, Image::FORMAT_RG8, VS::TEXTURE_TYPE_2D, VS::TEXTURE_FLAG_USED_FOR_STREAMING);
 		}
 		}
 
 
 		vs->texture_set_data(texture[CameraServer::FEED_Y_IMAGE], p_y_img);
 		vs->texture_set_data(texture[CameraServer::FEED_Y_IMAGE], p_y_img);
-		vs->texture_set_data(texture[CameraServer::FEED_CbCr_IMAGE], p_cbcr_img);
-		datatype = CameraFeed::FEED_YCbCr_Sep;
+		vs->texture_set_data(texture[CameraServer::FEED_CBCR_IMAGE], p_cbcr_img);
+		datatype = CameraFeed::FEED_YCBCR_SEP;
 	}
 	}
 }
 }
 
 

+ 2 - 2
servers/camera/camera_feed.h

@@ -50,8 +50,8 @@ public:
 	enum FeedDataType {
 	enum FeedDataType {
 		FEED_NOIMAGE, // we don't have an image yet
 		FEED_NOIMAGE, // we don't have an image yet
 		FEED_RGB, // our texture will contain a normal RGB texture that can be used directly
 		FEED_RGB, // our texture will contain a normal RGB texture that can be used directly
-		FEED_YCbCr, // our texture will contain a YCbCr texture that needs to be converted to RGB before output
-		FEED_YCbCr_Sep // our camera is split into two textures, first plane contains Y data, second plane contains CbCr data
+		FEED_YCBCR, // our texture will contain a YCbCr texture that needs to be converted to RGB before output
+		FEED_YCBCR_SEP // our camera is split into two textures, first plane contains Y data, second plane contains CbCr data
 	};
 	};
 
 
 	enum FeedPosition {
 	enum FeedPosition {

+ 2 - 2
servers/camera_server.cpp

@@ -47,9 +47,9 @@ void CameraServer::_bind_methods() {
 	ADD_SIGNAL(MethodInfo("camera_feed_removed", PropertyInfo(Variant::INT, "id")));
 	ADD_SIGNAL(MethodInfo("camera_feed_removed", PropertyInfo(Variant::INT, "id")));
 
 
 	BIND_ENUM_CONSTANT(FEED_RGBA_IMAGE);
 	BIND_ENUM_CONSTANT(FEED_RGBA_IMAGE);
-	BIND_ENUM_CONSTANT(FEED_YCbCr_IMAGE);
+	BIND_ENUM_CONSTANT(FEED_YCBCR_IMAGE);
 	BIND_ENUM_CONSTANT(FEED_Y_IMAGE);
 	BIND_ENUM_CONSTANT(FEED_Y_IMAGE);
-	BIND_ENUM_CONSTANT(FEED_CbCr_IMAGE);
+	BIND_ENUM_CONSTANT(FEED_CBCR_IMAGE);
 };
 };
 
 
 CameraServer *CameraServer::singleton = NULL;
 CameraServer *CameraServer::singleton = NULL;

+ 2 - 2
servers/camera_server.h

@@ -53,9 +53,9 @@ class CameraServer : public Object {
 public:
 public:
 	enum FeedImage {
 	enum FeedImage {
 		FEED_RGBA_IMAGE = 0,
 		FEED_RGBA_IMAGE = 0,
-		FEED_YCbCr_IMAGE = 0,
+		FEED_YCBCR_IMAGE = 0,
 		FEED_Y_IMAGE = 0,
 		FEED_Y_IMAGE = 0,
-		FEED_CbCr_IMAGE = 1,
+		FEED_CBCR_IMAGE = 1,
 		FEED_IMAGES = 2
 		FEED_IMAGES = 2
 	};
 	};