Преглед на файлове

Merge pull request #64870 from MarcusElg/naninfprinting3.x

[3.x] Improve string formatting (%f) for inf and nan
Rémi Verschelde преди 2 години
родител
ревизия
506f7d8360
променени са 2 файла, в които са добавени 13 реда и са изтрити 2 реда
  1. 5 2
      core/ustring.cpp
  2. 8 0
      main/tests/test_string.cpp

+ 5 - 2
core/ustring.cpp

@@ -4341,15 +4341,18 @@ String String::sprintf(const Array &values, bool *error) const {
 					double value = values[value_index];
 					double value = values[value_index];
 					bool is_negative = (value < 0);
 					bool is_negative = (value < 0);
 					String str = String::num(ABS(value), min_decimals);
 					String str = String::num(ABS(value), min_decimals);
+					bool not_numeric = isinf(value) || isnan(value);
 
 
 					// Pad decimals out.
 					// Pad decimals out.
-					str = str.pad_decimals(min_decimals);
+					if (!not_numeric) {
+						str = str.pad_decimals(min_decimals);
+					}
 
 
 					int initial_len = str.length();
 					int initial_len = str.length();
 
 
 					// Padding. Leave room for sign later if required.
 					// Padding. Leave room for sign later if required.
 					int pad_chars_count = (is_negative || show_sign) ? min_chars - 1 : min_chars;
 					int pad_chars_count = (is_negative || show_sign) ? min_chars - 1 : min_chars;
-					String pad_char = pad_with_zeros ? String("0") : String(" ");
+					String pad_char = (pad_with_zeros && !not_numeric) ? String("0") : String(" "); // Never pad NaN or inf with zeros
 					if (left_justified) {
 					if (left_justified) {
 						str = str.rpad(pad_chars_count, pad_char);
 						str = str.rpad(pad_chars_count, pad_char);
 					} else {
 					} else {

+ 8 - 0
main/tests/test_string.cpp

@@ -638,6 +638,14 @@ bool test_28() {
 	OS::get_singleton()->print(output_format, format.c_str(), output.c_str(), success ? "OK" : "FAIL");
 	OS::get_singleton()->print(output_format, format.c_str(), output.c_str(), success ? "OK" : "FAIL");
 	state = state && success;
 	state = state && success;
 
 
+	// Real (infinity) left-padded
+	format = "fish %11f frog";
+	args.clear();
+	args.push_back(INFINITY);
+	output = format.sprintf(args, &error);
+	success = (output == String("fish         inf frog") && !error);
+	state = state && success;
+
 	// Real right-padded
 	// Real right-padded
 	format = "fish %-11f frog";
 	format = "fish %-11f frog";
 	args.clear();
 	args.clear();