Sfoglia il codice sorgente

Merge pull request #69922 from adamscott/fix-tilemap-tileset-heap-use-after-free

Fix `heap-use-after-free` error in `TileMap::~TileMap()`
Rémi Verschelde 2 anni fa
parent
commit
52a0bba833
1 ha cambiato i file con 4 aggiunte e 0 eliminazioni
  1. 4 0
      scene/2d/tile_map.cpp

+ 4 - 0
scene/2d/tile_map.cpp

@@ -4090,5 +4090,9 @@ TileMap::TileMap() {
 }
 }
 
 
 TileMap::~TileMap() {
 TileMap::~TileMap() {
+	if (tile_set.is_valid()) {
+		tile_set->disconnect("changed", callable_mp(this, &TileMap::_tile_set_changed));
+	}
+
 	_clear_internals();
 	_clear_internals();
 }
 }