소스 검색

Don't expose underscored signals

kobewi 1 개월 전
부모
커밋
54c2eaee4d
2개의 변경된 파일10개의 추가작업 그리고 0개의 파일을 삭제
  1. 4 0
      editor/doc/doc_tools.cpp
  2. 6 0
      modules/gdscript/gdscript_editor.cpp

+ 4 - 0
editor/doc/doc_tools.cpp

@@ -660,6 +660,10 @@ void DocTools::generate(BitField<GenerateFlags> p_flags) {
 
 			if (signal_list.size()) {
 				for (const MethodInfo &mi : signal_list) {
+					if (mi.name.is_empty() || mi.name[0] == '_') {
+						continue; // Hidden, don't count.
+					}
+
 					DocData::MethodDoc signal;
 					signal.name = mi.name;
 					for (const PropertyInfo &arginfo : mi.arguments) {

+ 6 - 0
modules/gdscript/gdscript_editor.cpp

@@ -1290,6 +1290,9 @@ static void _find_identifiers_in_base(const GDScriptCompletionIdentifier &p_base
 							List<MethodInfo> signals;
 							scr->get_script_signal_list(&signals);
 							for (const MethodInfo &E : signals) {
+								if (E.name.begins_with("_")) {
+									continue;
+								}
 								int location = p_recursion_depth + _get_signal_location(scr, E.name);
 								ScriptLanguage::CodeCompletionOption option(E.name, ScriptLanguage::CODE_COMPLETION_KIND_SIGNAL, location);
 								r_result.insert(option.display, option);
@@ -1383,6 +1386,9 @@ static void _find_identifiers_in_base(const GDScriptCompletionIdentifier &p_base
 						List<MethodInfo> signals;
 						ClassDB::get_signal_list(type, &signals);
 						for (const MethodInfo &E : signals) {
+							if (E.name.begins_with("_")) {
+								continue;
+							}
 							int location = p_recursion_depth + _get_signal_location(type, StringName(E.name));
 							ScriptLanguage::CodeCompletionOption option(E.name, ScriptLanguage::CODE_COMPLETION_KIND_SIGNAL, location);
 							r_result.insert(option.display, option);