Parcourir la source

Merge pull request #56183 from raulsntos/fix-56180

Fix `KeyValuePairAt` memory leak
Ignacio Roldán Etcheverry il y a 3 ans
Parent
commit
54d89f2274
1 fichiers modifiés avec 2 ajouts et 4 suppressions
  1. 2 4
      modules/mono/glue/collections_glue.cpp

+ 2 - 4
modules/mono/glue/collections_glue.cpp

@@ -237,10 +237,8 @@ int32_t godot_icall_Dictionary_KeyValuePairs(Dictionary *ptr, Array **keys, Arra
 }
 
 void godot_icall_Dictionary_KeyValuePairAt(Dictionary *ptr, int index, MonoObject **key, MonoObject **value) {
-	Array *keys = godot_icall_Dictionary_Keys(ptr);
-	Array *values = godot_icall_Dictionary_Values(ptr);
-	*key = GDMonoMarshal::variant_to_mono_object(keys->get(index));
-	*value = GDMonoMarshal::variant_to_mono_object(values->get(index));
+	*key = GDMonoMarshal::variant_to_mono_object(ptr->get_key_at_index(index));
+	*value = GDMonoMarshal::variant_to_mono_object(ptr->get_value_at_index(index));
 }
 
 void godot_icall_Dictionary_Add(Dictionary *ptr, MonoObject *key, MonoObject *value) {