Browse Source

Merge pull request #27687 from Zylann/fix_heightmap_shape_min_max

Fix wrong heights data used to compute min and max heights
Rémi Verschelde 6 years ago
parent
commit
6a33727cb1
1 changed files with 5 additions and 4 deletions
  1. 5 4
      modules/bullet/shape_bullet.cpp

+ 5 - 4
modules/bullet/shape_bullet.cpp

@@ -510,16 +510,17 @@ void HeightMapShapeBullet::set_data(const Variant &p_data) {
 	// Compute min and max heights if not specified.
 	if (!d.has("min_height") && !d.has("max_height")) {
 
-		PoolVector<real_t>::Read r = heights.read();
-		int heights_size = heights.size();
+		PoolVector<real_t>::Read r = l_heights.read();
+		int heights_size = l_heights.size();
 
 		for (int i = 0; i < heights_size; ++i) {
 			real_t h = r[i];
 
-			if (h < l_min_height)
+			if (h < l_min_height) {
 				l_min_height = h;
-			else if (h > l_max_height)
+			} else if (h > l_max_height) {
 				l_max_height = h;
+			}
 		}
 	}