Browse Source

Merge pull request #39041 from swarnimarun/patch-1

Fix crashing of VisualScript due to function change
Rémi Verschelde 5 years ago
parent
commit
6a7b55805b
1 changed files with 6 additions and 0 deletions
  1. 6 0
      modules/visual_script/visual_script_editor.cpp

+ 6 - 0
modules/visual_script/visual_script_editor.cpp

@@ -3216,6 +3216,7 @@ void VisualScriptEditor::_move_nodes_with_rescan(const StringName &p_func_from,
 	{
 		List<VisualScript::DataConnection> data_connections;
 		script->get_data_connection_list(p_func_from, &data_connections);
+		int func_from_node_id = script->get_function_node_id(p_func_from);
 
 		HashMap<int, Map<int, Pair<int, int>>> connections;
 
@@ -3225,6 +3226,11 @@ void VisualScriptEditor::_move_nodes_with_rescan(const StringName &p_func_from,
 			int out_p = E->get().from_port;
 			int in_p = E->get().to_port;
 
+			// skip if the from_node is a function node
+			if (from == func_from_node_id) {
+				continue;
+			}
+
 			if (!connections.has(to)) {
 				connections.set(to, Map<int, Pair<int, int>>());
 			}