Browse Source

Fix JavaScript callback memory leak issue

Typo fix
SysError99 2 years ago
parent
commit
6a90164a03
1 changed files with 3 additions and 1 deletions
  1. 3 1
      platform/web/js/libs/library_godot_javascript_singleton.js

+ 3 - 1
platform/web/js/libs/library_godot_javascript_singleton.js

@@ -210,7 +210,9 @@ const GodotJSWrapper = {
 			// This is safe! JavaScript is single threaded (and using it in threads is not a good idea anyway).
 			GodotJSWrapper.cb_ret = null;
 			const args = Array.from(arguments);
-			func(p_ref, GodotJSWrapper.get_proxied(args), args.length);
+			const argsProxy = GodotJSWrapper.MyProxy(args);
+			func(p_ref, argsProxy.get_id(), args.length);
+			argsProxy.unref();
 			const ret = GodotJSWrapper.cb_ret;
 			GodotJSWrapper.cb_ret = null;
 			return ret;