Browse Source

Merge pull request #18726 from volzhs/remove-legacy

Remove android compatibility under API 16
Rémi Verschelde 7 years ago
parent
commit
720e2f7b09

+ 0 - 1
platform/android/build.gradle.template

@@ -21,7 +21,6 @@ allprojects {
 }
 
 dependencies {
-	compile 'com.android.support:support-v4:27.+'  // can be removed if minSdkVersion 16 and modify DownloadNotification.java & V14CustomNotification.java
 	$$GRADLE_DEPENDENCIES$$
 }
 

+ 4 - 6
platform/android/java/src/com/google/android/vending/expansion/downloader/impl/DownloadNotification.java

@@ -27,7 +27,6 @@ import android.app.NotificationManager;
 import android.app.PendingIntent;
 import android.content.Context;
 import android.os.Messenger;
-import android.support.v4.app.NotificationCompat;
 
 /**
  * This class handles displaying the notification associated with the download
@@ -49,9 +48,8 @@ public class DownloadNotification implements IDownloaderClient {
 
     private IDownloaderClient mClientProxy;
     final ICustomNotification mCustomNotification;
-    // NotificationCompat.Builder is used to support API < 16. This can be changed to Notification.Builder if minimum API >= 16.
-    private NotificationCompat.Builder mNotificationBuilder;
-    private NotificationCompat.Builder mCurrentNotificationBuilder;
+    private Notification.Builder mNotificationBuilder;
+    private Notification.Builder mCurrentNotificationBuilder;
     private CharSequence mLabel;
     private String mCurrentText;
     private PendingIntent mContentIntent;
@@ -187,7 +185,7 @@ public class DownloadNotification implements IDownloaderClient {
 
         void setTimeRemaining(long timeRemaining);
 
-        NotificationCompat.Builder updateNotification(Context c);
+        Notification.Builder updateNotification(Context c);
     }
 
     /**
@@ -220,7 +218,7 @@ public class DownloadNotification implements IDownloaderClient {
                 mContext.getSystemService(Context.NOTIFICATION_SERVICE);
         mCustomNotification = CustomNotificationFactory
                 .createCustomNotification();
-        mNotificationBuilder = new NotificationCompat.Builder(ctx);
+        mNotificationBuilder = new Notification.Builder(ctx);
         mCurrentNotificationBuilder = mNotificationBuilder;
 
     }

+ 3 - 5
platform/android/java/src/com/google/android/vending/expansion/downloader/impl/V14CustomNotification.java

@@ -22,7 +22,6 @@ import com.google.android.vending.expansion.downloader.Helpers;
 import android.app.Notification;
 import android.app.PendingIntent;
 import android.content.Context;
-import android.support.v4.app.NotificationCompat;
 
 public class V14CustomNotification implements DownloadNotification.ICustomNotification {
 
@@ -54,14 +53,13 @@ public class V14CustomNotification implements DownloadNotification.ICustomNotifi
         mCurrentKB = currentBytes;
     }
 
-    void setProgress(NotificationCompat.Builder builder) {
+    void setProgress(Notification.Builder builder) {
 
     }
 
     @Override
-    public NotificationCompat.Builder updateNotification(Context c) {
-        // NotificationCompat.Builder is used to support API < 16. This can be changed to Notification.Builder if minimum API >= 16.
-        NotificationCompat.Builder builder = new NotificationCompat.Builder(c);
+    public Notification.Builder updateNotification(Context c) {
+        Notification.Builder builder = new Notification.Builder(c);
         builder.setContentTitle(mTitle);
         if (mTotalKB > 0 && -1 != mCurrentKB) {
             builder.setProgress((int) (mTotalKB >> 8), (int) (mCurrentKB >> 8), false);