Procházet zdrojové kódy

Merge pull request #5502 from Paulb23/dock_connection_spam_issue_5498

Fixed signal connection prints when moving docks, issue 5498
Rémi Verschelde před 9 roky
rodič
revize
729e61e1d5

+ 3 - 1
scene/gui/color_ramp_edit.cpp

@@ -271,7 +271,9 @@ void ColorRampEdit::_input_event(const InputEvent& p_event) {
 void ColorRampEdit::_notification(int p_what) {
 
 	if (p_what==NOTIFICATION_ENTER_TREE) {
-		picker->connect("color_changed",this,"_color_changed");
+		if (!picker->is_connected("color_changed",this,"_color_changed")) {
+			picker->connect("color_changed",this,"_color_changed");
+		}
 	}
 	if (p_what==NOTIFICATION_DRAW) {
 

+ 3 - 1
scene/gui/line_edit.cpp

@@ -556,7 +556,9 @@ void LineEdit::_notification(int p_what) {
 				cursor_set_blink_enabled(EDITOR_DEF("text_editor/caret_blink", false));
 				cursor_set_blink_speed(EDITOR_DEF("text_editor/caret_blink_speed", 0.65));
 
-				EditorSettings::get_singleton()->connect("settings_changed",this,"_editor_settings_changed");
+				if (!EditorSettings::get_singleton()->is_connected("settings_changed",this,"_editor_settings_changed")) {
+					EditorSettings::get_singleton()->connect("settings_changed",this,"_editor_settings_changed");
+				}
 			}
 		} break;
 #endif

+ 8 - 2
tools/editor/editor_dir_dialog.cpp

@@ -99,8 +99,14 @@ void EditorDirDialog::_notification(int p_what) {
 
 	if (p_what==NOTIFICATION_ENTER_TREE) {
 		reload();
-		tree->connect("item_collapsed",this,"_item_collapsed",varray(),CONNECT_DEFERRED);
-		EditorFileSystem::get_singleton()->connect("filesystem_changed",this,"reload");
+
+		if (!tree->is_connected("item_collapsed",this,"_item_collapsed")) {
+			tree->connect("item_collapsed",this,"_item_collapsed",varray(),CONNECT_DEFERRED);
+		}
+
+		if (!EditorFileSystem::get_singleton()->is_connected("filesystem_changed",this,"reload")) {
+			EditorFileSystem::get_singleton()->connect("filesystem_changed",this,"reload");
+		}
 
 	}
 

+ 3 - 1
tools/editor/plugins/shader_graph_editor_plugin.cpp

@@ -176,7 +176,9 @@ void GraphColorRampEdit::_input_event(const InputEvent& p_event) {
 void GraphColorRampEdit::_notification(int p_what){
 
 	if (p_what==NOTIFICATION_ENTER_TREE) {
-		picker->connect("color_changed",this,"_color_changed");
+		if (!picker->is_connected("color_changed",this,"_color_changed")) {
+			picker->connect("color_changed",this,"_color_changed");
+		}
 	}
 	if (p_what==NOTIFICATION_DRAW) {