2
0
Эх сурвалжийг харах

Fix inefficient list iteration in Node

kobewi 1 жил өмнө
parent
commit
75ba837612
1 өөрчлөгдсөн 4 нэмэгдсэн , 4 устгасан
  1. 4 4
      scene/main/node.cpp

+ 4 - 4
scene/main/node.cpp

@@ -2963,12 +2963,12 @@ void Node::replace_by(Node *p_node, bool p_keep_groups) {
 	}
 
 	p_node->set_owner(owner);
-	for (int i = 0; i < owned.size(); i++) {
-		owned[i]->set_owner(p_node);
+	for (Node *E : owned) {
+		E->set_owner(p_node);
 	}
 
-	for (int i = 0; i < owned_by_owner.size(); i++) {
-		owned_by_owner[i]->set_owner(owner);
+	for (Node *E : owned_by_owner) {
+		E->set_owner(owner);
 	}
 
 	p_node->set_scene_file_path(get_scene_file_path());