Browse Source

Merge pull request #42915 from Yetizone/negative_lights_behavior

tonemap.glsl: Ensure color parameter of tonemap_reinhard() is positive
Rémi Verschelde 4 years ago
parent
commit
7d4921db1a
1 changed files with 4 additions and 0 deletions
  1. 4 0
      servers/rendering/rasterizer_rd/shaders/tonemap.glsl

+ 4 - 0
servers/rendering/rasterizer_rd/shaders/tonemap.glsl

@@ -157,6 +157,10 @@ vec3 tonemap_aces(vec3 color, float white) {
 }
 }
 
 
 vec3 tonemap_reinhard(vec3 color, float white) {
 vec3 tonemap_reinhard(vec3 color, float white) {
+	// Ensure color values are positive.
+	// They can be negative in the case of negative lights, which leads to undesired behavior.
+	color = max(vec3(0.0), color);
+
 	return (white * color + color) / (color * white + white);
 	return (white * color + color) / (color * white + white);
 }
 }