Browse Source

Fix regressions from Font refactor

Remove unnecessary font override
Fixes button outline draw when it should not, causing button colors to be slightly off
bruvzg 3 years ago
parent
commit
8f6c4956ca
2 changed files with 5 additions and 2 deletions
  1. 0 1
      editor/code_editor.cpp
  2. 5 1
      scene/gui/button.cpp

+ 0 - 1
editor/code_editor.cpp

@@ -1895,7 +1895,6 @@ CodeTextEditor::CodeTextEditor() {
 			} break;
 		}
 	}
-	text_editor->add_theme_font_override("font", fc);
 
 	text_editor->set_draw_line_numbers(true);
 	text_editor->set_highlight_matching_braces_enabled(true);

+ 5 - 1
scene/gui/button.cpp

@@ -342,7 +342,11 @@ void Button::_notification(int p_what) {
 				} break;
 			}
 
-			text_buf->draw_outline(ci, text_ofs, get_theme_constant(SNAME("outline_size")), get_theme_color(SNAME("font_outline_color")));
+			Color font_outline_color = get_theme_color(SNAME("font_outline_color"));
+			int outline_size = get_theme_constant(SNAME("outline_size"));
+			if (outline_size > 0 && font_outline_color.a > 0) {
+				text_buf->draw_outline(ci, text_ofs, outline_size, font_outline_color);
+			}
 			text_buf->draw(ci, text_ofs, color);
 		} break;
 	}