Pārlūkot izejas kodu

Merge pull request #17834 from Rubonnek/move-to-initializer-list

Move GodotSharp and MonoBuildTab member variables to initializer list
Rémi Verschelde 7 gadi atpakaļ
vecāks
revīzija
95b499644e

+ 6 - 7
modules/mono/editor/godotsharp_builds.cpp

@@ -525,11 +525,10 @@ void GodotSharpBuilds::BuildProcess::start(bool p_blocking) {
 	}
 	}
 }
 }
 
 
-GodotSharpBuilds::BuildProcess::BuildProcess(const MonoBuildInfo &p_build_info, GodotSharpBuild_ExitCallback p_callback) {
-
-	build_info = p_build_info;
-	build_tab = NULL;
-	exit_callback = p_callback;
-	exited = true;
-	exit_code = -1;
+GodotSharpBuilds::BuildProcess::BuildProcess(const MonoBuildInfo &p_build_info, GodotSharpBuild_ExitCallback p_callback) :
+		build_info(p_build_info),
+		build_tab(NULL),
+		exit_callback(p_callback),
+		exited(true),
+		exit_code(-1) {
 }
 }

+ 9 - 14
modules/mono/editor/mono_bottom_panel.cpp

@@ -437,21 +437,16 @@ void MonoBuildTab::_bind_methods() {
 	ClassDB::bind_method("_issue_activated", &MonoBuildTab::_issue_activated);
 	ClassDB::bind_method("_issue_activated", &MonoBuildTab::_issue_activated);
 }
 }
 
 
-MonoBuildTab::MonoBuildTab(const MonoBuildInfo &p_build_info, const String &p_logs_dir) {
-
-	build_info = p_build_info;
-	logs_dir = p_logs_dir;
-
-	build_exited = false;
-
-	issues_list = memnew(ItemList);
+MonoBuildTab::MonoBuildTab(const MonoBuildInfo &p_build_info, const String &p_logs_dir) :
+		build_info(p_build_info),
+		logs_dir(p_logs_dir),
+		build_exited(false),
+		issues_list(memnew(ItemList)),
+		error_count(0),
+		warning_count(0),
+		errors_visible(true),
+		warnings_visible(true) {
 	issues_list->set_v_size_flags(SIZE_EXPAND_FILL);
 	issues_list->set_v_size_flags(SIZE_EXPAND_FILL);
 	issues_list->connect("item_activated", this, "_issue_activated");
 	issues_list->connect("item_activated", this, "_issue_activated");
 	add_child(issues_list);
 	add_child(issues_list);
-
-	error_count = 0;
-	warning_count = 0;
-
-	errors_visible = true;
-	warnings_visible = true;
 }
 }