Browse Source

Mesh::convex_decompose: Remove unneeded vector copy

lupoDharkael 5 years ago
parent
commit
97d1149c3b
1 changed files with 2 additions and 8 deletions
  1. 2 8
      scene/resources/mesh.cpp

+ 2 - 8
scene/resources/mesh.cpp

@@ -543,15 +543,9 @@ Vector<Ref<Shape> > Mesh::convex_decompose() const {
 
 	ERR_FAIL_COND_V(!convex_composition_function, Vector<Ref<Shape> >());
 
-	Vector<Face3> faces = get_faces();
-	Vector<Face3> f3;
-	f3.resize(faces.size());
-	const Face3 *f = faces.ptr();
-	for (int i = 0; i < f3.size(); i++) {
-		f3.write[i] = f[i];
-	}
+	const Vector<Face3> faces = get_faces();
 
-	Vector<Vector<Face3> > decomposed = convex_composition_function(f3);
+	Vector<Vector<Face3> > decomposed = convex_composition_function(faces);
 
 	Vector<Ref<Shape> > ret;