Browse Source

Fix Dummy audio driver initialization issue on WASAPI output device initialization failure

`AudioDriverWASAPI::init` consistently returns `Error::OK`, even when encountering a failure during the initialization of the output device. This behaviour blocks the dummy driver from initializing in `AudioDriverManager::initialize`.
Alessandro Famà 1 year ago
parent
commit
998078f8d7
1 changed files with 3 additions and 5 deletions
  1. 3 5
      drivers/wasapi/audio_driver_wasapi.cpp

+ 3 - 5
drivers/wasapi/audio_driver_wasapi.cpp

@@ -557,13 +557,11 @@ Error AudioDriverWASAPI::init() {
 
 
 	target_latency_ms = Engine::get_singleton()->get_audio_output_latency();
 	target_latency_ms = Engine::get_singleton()->get_audio_output_latency();
 
 
-	Error err = init_output_device();
-	if (err != OK) {
-		ERR_PRINT("WASAPI: init_output_device error");
-	}
-
 	exit_thread.clear();
 	exit_thread.clear();
 
 
+	Error err = init_output_device();
+	ERR_FAIL_COND_V_MSG(err != OK, err, "WASAPI: init_output_device error.");
+
 	thread.start(thread_func, this);
 	thread.start(thread_func, this);
 
 
 	return OK;
 	return OK;